Repository navigation
Harden soTimeout vs InactivityMonitor - #2474
Merged
Merged
Conversation
mattrpav
force-pushed
the
amq-sotimeout-fix
branch
3 times, most recently
from
August 20, 2026 13:50
128d8c7 to
c393b9a
Compare
cshannon
requested changes
Aug 20, 2026
cshannon
reviewed
Aug 20, 2026
mattrpav
force-pushed
the
amq-sotimeout-fix
branch
from
August 20, 2026 15:48
c393b9a to
54fc416
Compare
cshannon
requested changes
Aug 20, 2026
…ity monitor - Impacts network connectors
…a in TcpTransport
mattrpav
force-pushed
the
amq-sotimeout-fix
branch
from
August 20, 2026 19:44
54fc416 to
50c76f3
Compare
cshannon
approved these changes
Aug 20, 2026
cshannon
left a comment
Contributor
There was a problem hiding this comment.
LGTM assuming tests are good
cshannon
added a commit
that referenced
this pull request
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden soTimeout to not conflict with InactivityMonitor. The current TcpTransport read check doesn't count bytes received, only if it looped without blocking or throwing an exception.