Repository navigation
Eclipse plugin for 1.14.0 and newer has version number 1.13.0 #744
Description
Activity
Thanks. This is the first release using a new GitHub actions workflow, and obviously something went wrong there.
I think the
mvn tycho-versions:update-eclipse-metadata -pl eclipse_pluginfailed to update the version numbers for the Eclipse plugin, and that it's probably an updated version just with the wrong version numbers:I'll try to sort it out.
Happened again for 1.15.0.
Reacted by Stefan Zabka, Max Bureck and Mike YoungstromReacted by Jonathan JogenforsForgot to update the version number in eclipse_plugin/pom.xml?
google-java-format/eclipse_plugin/pom.xml
Line 25 in edf036c
Note that as discussed in #835, the wrong version number also makes updating google-java-format tricky because if you just put a new JAR with the same version number in
dropins, it seems to be ignored (at least this is what it looks like for me). So it would be nice to get this fixed for new versions.- changed the title
[-]GitHub release page for 1.14.0 has Eclipse plugin 1.13.0[/-][+]Eclipse plugin for 1.14.0 and newer has version number 1.13.0[/+]on Feb 27, 2023 Occurred again for 1.16.0.
Happend again for v1.17.0.
The plugin not only keeps the old version but also includes the old version of the google-java-format.jar
#Created by Apache Maven 3.6.3 groupId=com.google.googlejavaformat artifactId=google-java-format version=1.13.0Happened again for 1.18.0.
@cushon Any chance to get this resolved? Upgrading the Eclipse plugin is tedious because of this because Eclipse silently ignores a new JAR if it has the same version number. I suspect that several issues about the Eclipse plugin here would be resolved if the version is fixed.
I am not currently using Eclipse and it isn't a supported IDE at my day job, which has been contributing the lack of support for Eclipse plugin here.
I adjusted the step that is supposed to be updated the versions for the eclipse plugin (https://github.com/google/google-java-format/blob/685a6c9ebd43aab9ef458379de7d3883bfee970f/.github/workflows/release.yml#L34C1-L35), and pushed a draft 1.18.1 release that seems have successfully updated the versions:
@PhilippWendler can you let me know if that looks good to you?
@cushon Thank you very much! I would love to test this, but the last link is not working for me, and https://github.com/google/google-java-format/releases/tag/v1.18.1 doesn't have any JARs. Could you maybe upload it here?
@PhilippWendler This is the build of the plugin: issue744.zip. (The
.zipcontainsgoogle-java-format-eclipse-plugin-1.18.1.jar.)Works perfectly for me!
I took my existing Eclipse installation with google-java-format 1.17.0 (which identifies itself as 1.13.0) and just put
google-java-format-eclipse-plugin-1.18.1.jarintodropins. After a restart of Eclipse, I see version 1.18.1 in the list of installed plugins, and the new version of the plugin is used. I verified this by attempting to format some code that triggers #959, which did not work before but now works.So from my point of view, this could be released officially. 🎉
Thanks a lot!
Reacted by Liam Miller-CushonGreat, thank you for testing! I have published the release: https://github.com/google/google-java-format/releases/tag/v1.18.1
Reacted by Philipp Wendler and bvo42Reacted by Philipp Wendler and bvo42- added 5 commits that reference this issue
on Oct 7, 2023
The release page on GitHub for 1.14.0 contains a
google-java-format-eclipse-plugin-1.13.0.jarbut not the expectedgoogle-java-format-eclipse-plugin-1.14.0.jar.