fix: do not download pnpm from get.pnpm.io

[zkochan]

close #44
close #22

[KSXGitHub]

This would effectively render the version input key pointless. Is this your intention?

[zkochan]

Not correct.

Nothing changed regarding version. pnpm is installing the specified version of pnpm. Before this change, pnpm was downloaded. This was causing issues. So now the pnpm which installs pnpm is committed to the project.

[KSXGitHub]

Ah, I see. I somehow forgot the workings of the code that I wrote/merged myself lol.

[zkochan]

Could you release it? I don't know how it is released.

[KSXGitHub]

So there are 2 pnpm.js files: One in dist, the other in src/install-pnpm. Is this excessive?

[zkochan]

it might be

why is the dist folder committed at all?

[KSXGitHub]

Wait, did you just merge? I was meant to make more review comment!

[zkochan]

ok, comment, I'll make another PR

[KSXGitHub]

Could you release it? I don't know how it is released.

Step 0: Make sure that you have enabled Two Factor Authentication (2-FA) on GitHub.
Step 1: Use git tag to tag a version (and then push the tag).
Step 2: Go to the Release Page on GitHub.
Step 3: Click on the tag.
Step 4: Create a release.
Step 5: Remember to check the Marketplace checkbox.

[zkochan]

Thanks, we'll have to add that to a CONTRIBUTING.md

[KSXGitHub]

why is the dist folder committed at all?

The dist contains index.js which is what the "engine" of GitHub Actions would execute. Because the "engine" can't understand TypeScript.

[zkochan]

can we generate it before packing?

[KSXGitHub]

can we generate it before packing?

I think there's a command in package.json that generates dist/index.js. I always make sure to execute it before commit, though not automatically yet.