Revert "Adding small test update for temp dir using t.TempDir (#13293)" - #13344
Merged
Merged
Conversation
This reverts commit 2ddb359. Various tests are failing in CI after this change; reverting to free up other work. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
bboreham
force-pushed
the
revert-13293
branch
from
December 30, 2023 19:17
288f4c8 to
252031c
Compare
This was referenced Dec 30, 2023
Contributor
|
@bboreham thanks for update and taking the time to fix this, I had only good intentions and will take a look what was wrong and was this even good approach |
Member
Author
|
Sure; no blame or criticism. It's getting into my evening so I just want to do the simple thing to get back to a working CI. |
SuperQ
approved these changes
Dec 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2ddb359 ; PR #13293 .
Various tests are failing in CI after this change; reverting to free up other work.