Repository navigation
馃悰 fix(ci): mark real-shell activation tests as slow - #3243
Merged
Merged
Conversation
The graalpy CI leg spends about half its runtime (roughly 16 of 32 minutes on Ubuntu, 6.5 of 16 on macOS) in test_bash, test_csh, test_fish, and test_nushell, each spawning a real shell per parametrization to verify activation scripts work. That verification is interpreter-independent: the scripts are pure Python string templates, and every CPython CI leg already exercises the same shell x prompt x tcl x env matrix in a fraction of the time. GraalPy re-running it adds wall-clock without adding coverage. test_powershell already carries @pytest.mark.slow for the same reason; these four just never got it. graalpy is the only env that passes --skip-slow, so nothing changes for any other interpreter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graalpy CI leg that #3240 just fixed for reliability still takes 32-38 minutes, and half of that time goes to
test_bash,test_csh,test_fish, andtest_nushell. Measured on the merged run: 16.3 of 32.4 minutes on Ubuntu, 6.5 of 15.9 on macOS, each test spawning a real shell perprompt/tcl/envcombination to verify the generated activation script works.That verification doesn't depend on which interpreter created the virtualenv. The activation scripts are plain Python string templates, and CPython CI legs already run the same shell x prompt x tcl x env matrix in a fraction of the time, since GraalPy's per-process subprocess and JIT overhead is what pushes each of these tests to 18-25 seconds instead of well under one. Re-running that shell-integration matrix under GraalPy costs wall-clock time without adding coverage specific to GraalPy.
test_powershellalready carries@pytest.mark.slowfor this exact reason; these four never got it, which reads as an oversight rather than a deliberate choice given the existing precedent. Sincegraalpyis the only tox environment that passes--skip-slow, other interpreters' CI legs keep full activation coverage unchanged.