Surface and filter ai classification on results show(AST-178033) - #1579
Closed
cx-sumit-morchhale wants to merge 4 commits into
Closed
cx-sumit-morchhale wants to merge 4 commits into
cx-sumit-morchhale wants to merge 4 commits into
Conversation
Contributor
Security Policy Alert: Secret Policy ViolationThis workflow run has been blocked by StepSecurity's secrets policy because it accesses secrets and the workflow file differs from the default branch. Secret references detected:
To approve this workflow, please add the Note: The label must be added by someone other than the PR author (cx-sumit-morchhale) or automation bots to ensure proper security review. After the label is added, you can re-run the blocked workflow to proceed. This workflow will be automatically approved once merged into the default branch. For more information, see StepSecurity's Secret Exfiltration Policy documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiClassificationfield (TP/FP/UNCLASSIFIED/NOT_ANALYZED) thatast-resultsnow returns onGET /api/resultsfor SAST results (AST-175453) into both the CLI's JSON and SARIF reports — previously silently dropped sinceScanResultDatahad no matching field.--filter "ai-classification=TP;FP"pass-through inresults show's help text (filtering already worked by accident via the generic--filtermechanism; this just makes it discoverable).ast-resultssends.Changes
internal/wrappers/results-json.go— addAIClassification *string(omitempty) toScanResultData.internal/wrappers/results-sarif.go— addAIClassification *string(omitempty) toSarifResultProperties.internal/commands/result.go— populateSarifResultProperties.AIClassificationinparseSarifResultSastwhen present; listai-classificationinfilterResultsListFlagUsage.internal/params/flags.go— addAIClassificationQueryParamconstant.internal/wrappers/mock/results-mock.go— seed one mock SAST result with a classification for test coverage.internal/commands/result_test.go— cover present/absent cases for both JSON and SARIF output.Out of scope
sonarandgl-sastreports (externally-owned schemas, no field for this) andpdf(server-rendered) — unchanged.