fix: keep recurring tasks scheduled after failed runs - #27
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design question
Today a recurring (interval) scheduled task keeps repeating only after a successful run. If a run fails, it is not claimed again. I could not tell whether that is intended. This PR proposes the other behavior. If success-only repetition is what you want, please close this with a word and I will not mind.
What this changes
Tradeoff
A failed recurring task now keeps making provider requests at the same interval, where before it stopped. That is the cost to weigh against a task that silently stops after one bad run.
Tests
Added a test on the real SQLite store covering the due time, exclusive claim and history across two connections. It fails on the base commit. There are six scenarios in total, including the one-shot, the pause or cancel with a late failure, and removing or editing the schedule.
Results below are from the person who prepared the change; I did not rerun them. Full suite: 34 files, 162 tests pass. Format, lint, typecheck and production build pass (the build prints a chunk size warning that was already there). No dependency changes.