Skip to content

fix(chat): ignore composer Enter during IME composition - #40

Merged
jerelvelarde merged 1 commit into
CopilotKit:mainfrom
boss477:fix/composer-ime-enter
Oct 5, 2026
Merged

jerelvelarde merged 1 commit into
CopilotKit:mainfrom
boss477:fix/composer-ime-enter

Conversation

@boss477

@boss477 boss477 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • avoid submitting the chat composer when Enter is pressed during active IME composition
  • keep normal Enter-to-send and Shift+Enter multiline behavior unchanged
  • add focused regression coverage for composing, legacy keyCode 229, normal Enter, and Shift+Enter

Fixes #37

Tests

  • npm test -- --run tests/chat-composer.test.ts tests/transcript.test.tsx
  • npm run typecheck
  • npm run lint
  • npx prettier --check src/client/Chat.tsx src/client/chat-composer.ts tests/chat-composer.test.ts

@jerelvelarde jerelvelarde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevents Enter from submitting incomplete IME input while preserving normal Enter and Shift+Enter behavior. Strong accessibility and international input fit for the template. No new dependencies, authority, or security blockers found. Regression coverage includes active composition and legacy keyCode 229.

Validation on the reviewed head: 168 tests passed; typecheck, lint, formatting, and production build passed.

@jerelvelarde
jerelvelarde merged commit 005ea4f into CopilotKit:main Oct 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composer: avoid submitting Enter while IME composition is active

2 participants