Support Cucumber 8 in latestDep tests by daniel-mohedano · Pull Request #12753 · DataDog/dd-trace-java

daniel-mohedano · 2026-10-06T09:45:31Z

What Does This Do

Lets the cucumber latestDep tests run against Cucumber 8.

Updates the latestDep lockfiles of cucumber-5.4, junit-4-cucumber-5.4 and junit-5-cucumber-5.4 to Cucumber 8.0.4. Cucumber 8 also brings in JUnit 6.1.3.
Runs latestDepTest in these three modules only on Java 17 and above. Cucumber 8 and JUnit 6 are built for Java 17. On older JVMs the task is skipped.
Adds a latest7Test suite to the three modules. It tests the latest Cucumber 7.x (currently 7.34.9) on every JVM, so Java 8 and 11 users stay covered.
junit-5-cucumber-5.4 tests now read the Cucumber version from io.cucumber.core.options.Constants instead of io.cucumber.core.api.TypeRegistry. Cucumber 8 removed TypeRegistry. Constants exists from 5.4 to 8.

Motivation

The automated dependency update in #12747 bumped these modules to Cucumber 8.0.4 and broke CI:

junit-5-cucumber-5.4 failed to compile its tests because TypeRegistry no longer exists.
With that fixed, latestDepTest fails on Java 8 with UnsupportedClassVersionError.

The cucumber lockfiles were reverted in #12747 to unblock it. This PR restores them with the fixes above.

Additional Notes

The instrumentation code is unchanged and works with Cucumber 8.

The latest7Test lockfile entries only add the new configurations. Existing locked versions are unchanged.

Verified locally:

test, cucumber76Test, cucumber723Test and latest7Test pass on Java 8.
latestDepTest passes on Java 17 with Cucumber 8.0.4 for all three modules.
latestDepTest is skipped on Java 8.
spotlessCheck passes.

Not run locally: muzzle against Cucumber 8.

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Cucumber 8 removed io.cucumber.core.api.TypeRegistry and requires Java 17.

cit-pr-commenter-54b7da · 2026-10-06T10:02:02Z

CI Visibility Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	57.56	56.55	$\color{red}{\blacktriangle}$ +1.01	56.55	$\color{red}{\blacktriangle}$ +1.01	88/306
agentEvpProxy	57.95	n/a	n/a	n/a	n/a	-

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:05:21Z

CI Visibility Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	37.94	37.91	$\color{red}{\blacktriangle}$ +0.03	37.15	$\color{red}{\blacktriangle}$ +0.79	45/172
agentless	37.08	37.15	$\color{green}{\blacktriangledown}$ -0.07	36.42	$\color{red}{\blacktriangle}$ +0.66	46/145
agentlessCodeCoverage	45.23	45.38	$\color{green}{\blacktriangledown}$ -0.15	45.38	$\color{green}{\blacktriangledown}$ -0.15	45/144
agentlessLineCoverage	57.02	56.55	$\color{red}{\blacktriangle}$ +0.47	56.55	$\color{red}{\blacktriangle}$ +0.47	45/145

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:06:36Z

CI Visibility Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	89.35	89.58	$\color{green}{\blacktriangledown}$ -0.23	89.58	$\color{green}{\blacktriangledown}$ -0.23	45/173
agentless	81.61	82.69	$\color{green}{\blacktriangledown}$ -1.08	81.05	$\color{red}{\blacktriangle}$ +0.56	45/141
agentlessCodeCoverage	96.67	97.04	$\color{green}{\blacktriangledown}$ -0.37	97.04	$\color{green}{\blacktriangledown}$ -0.37	45/141
agentlessLineCoverage	112.77	113.88	$\color{green}{\blacktriangledown}$ -1.11	111.62	$\color{red}{\blacktriangle}$ +1.15	44/143

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

datadog-prod-us1-6 · 2026-10-06T10:07:05Z

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 57.83% (-1.50%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: d51e352 | Docs | Give us feedback!}

cit-pr-commenter-54b7da · 2026-10-06T10:07:32Z

CI Visibility Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	22.91	22.09	$\color{red}{\blacktriangle}$ +0.82	22.09	$\color{red}{\blacktriangle}$ +0.82	46/179
agentless	19.84	19.59	$\color{red}{\blacktriangle}$ +0.25	19.20	$\color{red}{\blacktriangle}$ +0.64	44/141
agentlessCodeCoverage	20.39	19.99	$\color{red}{\blacktriangle}$ +0.40	19.99	$\color{red}{\blacktriangle}$ +0.40	44/141
agentlessLineCoverage	27.11	26.98	$\color{red}{\blacktriangle}$ +0.13	26.98	$\color{red}{\blacktriangle}$ +0.13	34/91

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:07:36Z

CI Visibility Test Environment - pass4s

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	9.29	10.13	$\color{green}{\blacktriangledown}$ -0.84	9.92	$\color{green}{\blacktriangledown}$ -0.63	45/159
agentless	10.06	10.13	$\color{green}{\blacktriangledown}$ -0.07	9.54	$\color{red}{\blacktriangle}$ +0.52	45/131
agentlessCodeCoverage	17.24	17.73	$\color{green}{\blacktriangledown}$ -0.49	17.03	$\color{red}{\blacktriangle}$ +0.21	41/122

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:09:08Z

CI Visibility Test Environment - heliboard

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	9.57	9.73	$\color{green}{\blacktriangledown}$ -0.16	9.92	$\color{green}{\blacktriangledown}$ -0.35	44/138

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:14:47Z

CI Visibility Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	13.69	13.40	$\color{red}{\blacktriangle}$ +0.29	13.13	$\color{red}{\blacktriangle}$ +0.56	45/178
agentless	12.47	12.12	$\color{red}{\blacktriangle}$ +0.35	12.12	$\color{red}{\blacktriangle}$ +0.35	45/141
agentlessCodeCoverage	14.78	15.72	$\color{green}{\blacktriangledown}$ -0.94	15.11	$\color{green}{\blacktriangledown}$ -0.33	45/141
agentlessLineCoverage	17.56	17.03	$\color{red}{\blacktriangle}$ +0.53	17.38	$\color{red}{\blacktriangle}$ +0.18	44/141

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:17:25Z

CI Visibility Test Environment - jolokia

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	96.69	95.12	$\color{red}{\blacktriangle}$ +1.57	95.12	$\color{red}{\blacktriangle}$ +1.57	45/174
agentless	91.56	89.58	$\color{red}{\blacktriangle}$ +1.98	89.58	$\color{red}{\blacktriangle}$ +1.98	45/145
agentlessCodeCoverage	101.69	99.00	$\color{red}{\blacktriangle}$ +2.69	99.00	$\color{red}{\blacktriangle}$ +2.69	45/146
agentlessLineCoverage	102.77	101.00	$\color{red}{\blacktriangle}$ +1.77	101.00	$\color{red}{\blacktriangle}$ +1.77	45/149

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:24:05Z

CI Visibility Test Environment - okhttp

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	19.23	19.99	$\color{green}{\blacktriangledown}$ -0.76	19.99	$\color{green}{\blacktriangledown}$ -0.76	45/167
agentless	18.48	19.59	$\color{green}{\blacktriangledown}$ -1.11	19.59	$\color{green}{\blacktriangledown}$ -1.11	48/140
agentlessCodeCoverage	22.74	22.99	$\color{green}{\blacktriangledown}$ -0.25	22.99	$\color{green}{\blacktriangledown}$ -0.25	49/141
agentlessLineCoverage	39.26	40.25	$\color{green}{\blacktriangledown}$ -0.99	39.45	$\color{green}{\blacktriangledown}$ -0.19	46/139

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

dd-octo-sts · 2026-10-06T10:30:28Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.00 s	13.96 s	[-0.6%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent	12.95 s	12.98 s	[-0.9%; +0.6%] (no difference)
startup:petclinic:appsec:Agent	16.72 s	17.06 s	[-6.4%; +2.4%] (no difference)
startup:petclinic:iast:Agent	17.00 s	17.09 s	[-1.5%; +0.4%] (no difference)
startup:petclinic:profiling:Agent	16.51 s	16.73 s	[-2.6%; -0.1%] (maybe better)
startup:petclinic:sca:Agent	17.02 s	16.99 s	[-0.9%; +1.3%] (no difference)
startup:petclinic:tracing:Agent	15.60 s	15.76 s	[-7.8%; +5.7%] (unstable)

Commit: d51e3525 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

cit-pr-commenter-54b7da · 2026-10-06T10:30:57Z

CI Visibility Test Environment - spring_boot

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	16.13	16.36	$\color{green}{\blacktriangledown}$ -0.23	16.36	$\color{green}{\blacktriangledown}$ -0.23	45/167
agentless	9.70	9.92	$\color{green}{\blacktriangledown}$ -0.22	9.92	$\color{green}{\blacktriangledown}$ -0.22	45/137
agentlessCodeCoverage	13.77	13.67	$\color{red}{\blacktriangle}$ +0.10	13.67	$\color{red}{\blacktriangle}$ +0.10	47/139
agentlessLineCoverage	22.41	22.54	$\color{green}{\blacktriangledown}$ -0.13	22.54	$\color{green}{\blacktriangledown}$ -0.13	45/139

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

cit-pr-commenter-54b7da · 2026-10-06T10:53:33Z

CI Visibility Test Environment - sonar-java

Job Status: 🟢 success

Scenario	This PR (%)	7d median	Δ 7d	30d median	Δ 30d	runs (7d/30d)
agent	-5.88	10.13	$\color{green}{\blacktriangledown}$ -16.01	13.40	$\color{green}{\blacktriangledown}$ -19.28	45/173
agentless	29.73	19.20	$\color{red}{\blacktriangle}$ +10.53	11.65	$\color{red}{\blacktriangle}$ +18.08	45/145
agentlessCodeCoverage	52.16	79.45	$\color{green}{\blacktriangledown}$ -27.29	79.45	$\color{green}{\blacktriangledown}$ -27.29	46/145
agentlessLineCoverage	120.67	125.85	$\color{green}{\blacktriangledown}$ -5.18	123.36	$\color{green}{\blacktriangledown}$ -2.69	44/147

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

chatgpt-codex-connector · 2026-10-06T11:31:28Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-06T11:33:58.442994Z	`8e36bb8`	Draft marked ready
🔒 Security Review	✅ Completed 2026-10-06T11:34:36.759694Z	`8e36bb8`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadog-prod-us1-6

More details

The Java 17 gate excludes unsupported runtimes, and the replacement version lookup remains compatible with Cucumber 5.4 and 8. Latest-dependency execution was verified on Java 17 and 21.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 8e36bb8 · @DataDog review to ask questions}

Cucumber 8 requires Java 17, so latestDepTest no longer covers Java 8 and 11 users on cucumber 7.

fix(ci-visibility): support cucumber 8 in latestDep tests

8e36bb8

Cucumber 8 removed io.cucumber.core.api.TypeRegistry and requires Java 17.

daniel-mohedano added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM labels Oct 6, 2026

daniel-mohedano marked this pull request as ready for review October 6, 2026 11:31

daniel-mohedano requested review from a team as code owners October 6, 2026 11:31

daniel-mohedano requested review from amarziali and vandonr and removed request for a team October 6, 2026 11:31

gnufede approved these changes Oct 6, 2026

View reviewed changes

amarziali approved these changes Oct 6, 2026

View reviewed changes

datadog-prod-us1-6 Bot reviewed Oct 6, 2026

View reviewed changes

vandonr approved these changes Oct 6, 2026

View reviewed changes

AlexeyKuznetsov-DD approved these changes Oct 6, 2026

View reviewed changes

test(ci-visibility): test latest cucumber 7.x on all JVMs

d51e352

Cucumber 8 requires Java 17, so latestDepTest no longer covers Java 8 and 11 users on cucumber 7.

Conversation

daniel-mohedano commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - sbt-scalatest

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - nebula-release-plugin

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - netflix-zuul

Uh oh!

datadog-prod-us1-6 Bot commented Oct 6, 2026 • edited by datadog-datadog-prod-us1-2 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - reactive-streams-jvm

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - pass4s

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - heliboard

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - sonar-kotlin

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - jolokia

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - okhttp

Uh oh!

dd-octo-sts Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - spring_boot

Uh oh!

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Visibility Test Environment - sonar-java

Uh oh!

chatgpt-codex-connector Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

datadog-prod-us1-6 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

daniel-mohedano commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

datadog-prod-us1-6 Bot commented Oct 6, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

dd-octo-sts Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Oct 6, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 6, 2026 •

edited

Loading