Repository navigation
Add embedded invite enhancements: roles, field invite state, delete endpoint - #2
Merged
VitaliiSkuratovskyi merged 1 commit intoAug 4, 2026
Conversation
VitaliiSkuratovskyi
deleted the
feature/TECH-3959_embedding_invites_additions
branch
August 4, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR expands embedded-invite support with role metadata, role-ID-based invitations, signer identity fields, field-invite state, and a document-scoped delete operation.
Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking test-strengthening opportunity for the new delete endpoint.
The implementation follows existing client and service conventions, while the only accepted concern is that its test would not detect incorrect endpoint arguments.
Files Needing Attention: client-lib/src/test/java/com/signnow/library/services/DocumentsServiceTest.java
Important Files Changed
Sequence Diagram
sequenceDiagram participant Caller participant DocumentsService participant SNClient participant SignNowAPI Caller->>DocumentsService: deleteDocumentEmbeddedSignInvite(documentId) DocumentsService->>SNClient: "DELETE /v2/documents/{document_id}/embedded-invites" SNClient->>SignNowAPI: DELETE resolved document endpoint SignNowAPI-->>SNClient: Success or API error SNClient-->>DocumentsService: Decode/discard String response DocumentsService-->>Caller: void or SNExceptionReviews (1): Last reviewed commit: "Add embedded invite enhancements: roles,..." | Re-trigger Greptile