Skip to content

Add embedded invite enhancements: roles, field invite state, delete endpoint - #2

Merged
VitaliiSkuratovskyi merged 1 commit into
masterfrom
feature/TECH-3959_embedding_invites_additions
Aug 4, 2026
Merged

VitaliiSkuratovskyi merged 1 commit into
masterfrom
feature/TECH-3959_embedding_invites_additions

Conversation

@VitaliiSkuratovskyi

@VitaliiSkuratovskyi VitaliiSkuratovskyi commented Aug 3, 2026 •

Copy link
Copy Markdown

Greptile Summary

The PR expands embedded-invite support with role metadata, role-ID-based invitations, signer identity fields, field-invite state, and a document-scoped delete operation.

  • Adds role and embedded-invite fields to the document DTO.
  • Adds a factory for creating invites using role IDs.
  • Exposes and implements deletion of document embedded invites.
  • Increments the client library version to 1.0.7 and adds service-level test coverage.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking test-strengthening opportunity for the new delete endpoint.

The implementation follows existing client and service conventions, while the only accepted concern is that its test would not detect incorrect endpoint arguments.

Files Needing Attention: client-lib/src/test/java/com/signnow/library/services/DocumentsServiceTest.java

Important Files Changed

Filename Overview
client-lib/src/main/java/com/signnow/library/dto/Document.java Adds response mappings for roles and field-invite state plus optional embedded-invite identity fields and a role-ID factory; no concrete mapping defect was established.
client-lib/src/main/java/com/signnow/library/facades/Documents.java Adds the document-scoped embedded-invite deletion operation to the public facade.
client-lib/src/main/java/com/signnow/library/services/DocumentsService.java Implements embedded-invite deletion using the same endpoint and path-template conventions as the existing create operation.
client-lib/src/test/java/com/signnow/library/services/DocumentsServiceTest.java Covers invocation of the new delete method but does not assert its endpoint-specific request arguments.
client-lib/pom.xml Increments the client artifact version from 1.0.6 to 1.0.7 without changing dependencies.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant DocumentsService
    participant SNClient
    participant SignNowAPI
    Caller->>DocumentsService: deleteDocumentEmbeddedSignInvite(documentId)
    DocumentsService->>SNClient: "DELETE /v2/documents/{document_id}/embedded-invites"
    SNClient->>SignNowAPI: DELETE resolved document endpoint
    SignNowAPI-->>SNClient: Success or API error
    SNClient-->>DocumentsService: Decode/discard String response
    DocumentsService-->>Caller: void or SNException
Loading

Reviews (1): Last reviewed commit: "Add embedded invite enhancements: roles,..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@VitaliiSkuratovskyi
VitaliiSkuratovskyi merged commit de6c526 into master Aug 4, 2026
1 check passed
@VitaliiSkuratovskyi
VitaliiSkuratovskyi deleted the feature/TECH-3959_embedding_invites_additions branch August 4, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant