Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
|
rbri
reviewed
Sep 24, 2026
|
|
||
| if (value.indexOf(' ') != -1) { | ||
| throw new InvalidSelectorException("Compound class names not permitted; contains blank"); | ||
| throw new InvalidSelectorException("Compound class names not permitted; contains blank: " + value); |
Collaborator
There was a problem hiding this comment.
Lets enclose the value in single quotes to make also trailing, leading blanks visible. Same for the others
Author
There was a problem hiding this comment.
I understand the problem right here and added the quotes to this message, but for CSS selectors this is not really necessary, because leading and trailing spaces are ignored anyway.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for changing the error messages of
HtmlUnitDriver.findElement(By.cssSelector(...)), as described in #164.