fix(docs): prevent destructuring undefined loaderData - #1320
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | ca26fd9 | Commit Preview URL Branch Preview URL |
Sep 30 2026, 11:08 PM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeErrorthat occurs whenDocs()components attempt to destructurecontent,filePath, andtitlefromRoute.useLoaderData()when the loader data isundefined.The issue arises during client-side navigation, particularly when navigating to docs paths that implicitly redirect (e.g., a framework-less path redirecting to a framework-specific path). In such scenarios, the component can render before the loader has resolved its data or after a redirect has been initiated, leading to
useLoaderData()returningundefined.To fix this, a guard has been added to both
src/routes/_library/$libraryId/$version.docs.$.tsxandsrc/routes/_library/$libraryId/$version.docs.framework.$framework.$.tsx.Changes made:
Route.useLoaderData()is now assigned to aloaderDatavariable.useParams,useLoaderData,useMatch,useLocation) are called before any conditional return to maintain stable hook order.if (!loaderData) return null;is introduced. This prevents destructuringundefinedand allows the component to gracefully handle the transient state where loader data is not yet available.content,filePath, andtitlenow happens from theloaderDatavariable, only after it's confirmed to be defined.This approach aligns with the existing optional chaining (
loaderData?.title) already present in thehead()andheaders()functions within the same route, ensuring consistent handling of potentially undefined loader data.Fixes TANSTACK-COM-52Z
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.