Repository navigation
Conversation
Add makeElemDrop and call it from makeBulkMemory.
tlively
requested review from
kripken and
stevenfontanella
and removed request for
a team and
stevenfontanella
October 3, 2026 18:43
kripken
reviewed
Oct 5, 2026
| Expression* TranslateToFuzzReader::makeBulkMemory(Type type) { | ||
| if (!allowMemory) { | ||
| return makeTrivial(type); | ||
| } |
Member
There was a problem hiding this comment.
What removed the need for this check?
Member
Author
There was a problem hiding this comment.
It turns out that makeMemoryInit, makeMemoryCopy, and makeMemoryFill already do this check. makeDataDrop and makeElemDrop can still make sense to do even when there is no memory.
Member
Author
|
(I will go through and update the fuzz stats tests on each of these PRs once the stack is otherwise ready to merge.) |
kripken
approved these changes
Oct 5, 2026
kripken
left a comment
Member
There was a problem hiding this comment.
Some of these PRs (like this one) make traps more likely. We should review the trap rate after they all land perhaps.
Member
Author
|
Sure, I can take a look at that. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add makeElemDrop and call it from makeBulkMemory.