Repository navigation
Conversation
For i64 pair tuples in _makeConcrete, add makeWideIntExpression with VeryImportant weight (requiring Multivalue as well as WideArithmetic) alongside makeTupleMake instead of replacing it half the time with default weight. This increases generation of unextracted (i64, i64) wide arithmetic expressions by ~4.2x.
kripken
reviewed
Oct 5, 2026
| options.add(FeatureSet::Multivalue, &Self::makeTupleMake); | ||
| options.add(FeatureSet::Multivalue, &Self::makeTupleMake); | ||
| if (type == Types::getI64Pair()) { | ||
| options.add(FeatureSet::WideArithmetic | FeatureSet::Multivalue, |
Member
There was a problem hiding this comment.
Suggested change
| options.add(FeatureSet::WideArithmetic | FeatureSet::Multivalue, | |
| // Use VeryImportant here, as it is rare to have i64 pairs - when we finally have one, be likely to handle it. | |
| options.add(FeatureSet::WideArithmetic | FeatureSet::Multivalue, |
Is this indeed the motivation?
Member
Author
There was a problem hiding this comment.
Yes, inasmuch as increasing the frequency of wide arithmetic instructions is the motivation, although I think getting rid of the unnecessary oneIn(2) above is the more important change from a code consistency perspective.
Member
There was a problem hiding this comment.
(imo feels worth a comment as otherwise it may not be clear to a reader of the source)
kripken
approved these changes
Oct 5, 2026
| options.add(FeatureSet::Multivalue, &Self::makeTupleMake); | ||
| options.add(FeatureSet::Multivalue, &Self::makeTupleMake); | ||
| if (type == Types::getI64Pair()) { | ||
| options.add(FeatureSet::WideArithmetic | FeatureSet::Multivalue, |
Member
There was a problem hiding this comment.
(imo feels worth a comment as otherwise it may not be clear to a reader of the source)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For i64 pair tuples in _makeConcrete, add makeWideIntExpression with
VeryImportant weight (requiring Multivalue as well as WideArithmetic)
alongside makeTupleMake instead of replacing it half the time with
default weight. This increases generation of unextracted (i64, i64)
wide arithmetic expressions by ~4.2x.