Repository navigation
Detect authors in multi-line contributor lists - #5342
Open
Vaibhav200303 wants to merge 2 commits into
Open
Vaibhav200303 wants to merge 2 commits into
Vaibhav200303 wants to merge 2 commits into
Conversation
Use lexer line numbers to create one author detection per contributor when an explicit marker is followed by at least two name/contact lines. Add a regression fixture for the govalidator contributor list. Signed-off-by: Vaibhav Sharma <vs9109807@gmail.com>
Update the NVIDIA CUDA supplement license metadata to list its multiline authors separately, matching the author detections introduced for aboutcode-org#5138. Signed-off-by: Vaibhav Sharma <vs9109807@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5138
Summary
ScanCode currently combines contributors from certain multi-line Markdown
contributor lists into a single author detection. In the reported govalidator
README, the final contributor is also omitted.
This change uses the source line information already retained by lexer tokens
to emit one
AuthorDetectionper contributor line.The behavior is intentionally limited to explicit author/contributor lists
where:
The split is applied only to the relevant parsed
AUTHORtree, avoidingchanges to the general copyright grammar.
Changes
CHANGELOG.rst.AUTHORS.rst.Testing
1 passed4738 passed, 13 xfailedgit diff --check: passedThe repository-wide standard suite was also run before the change on Windows.
It contains pre-existing environment/platform-related failures unrelated to
this patch.