Skip to content

Detect authors in multi-line contributor lists - #5342

Open
Vaibhav200303 wants to merge 2 commits into
aboutcode-org:developfrom
Vaibhav200303:fix-5138-split-contributor-authors
Open

Vaibhav200303 wants to merge 2 commits into
aboutcode-org:developfrom
Vaibhav200303:fix-5138-split-contributor-authors

Conversation

@Vaibhav200303

Copy link
Copy Markdown

Fixes #5138

Summary

ScanCode currently combines contributors from certain multi-line Markdown
contributor lists into a single author detection. In the reported govalidator
README, the final contributor is also omitted.

This change uses the source line information already retained by lexer tokens
to emit one AuthorDetection per contributor line.

The behavior is intentionally limited to explicit author/contributor lists
where:

  • at least two entries follow the marker;
  • each entry contains at least two name tokens;
  • each entry contains a URL or email; and
  • no unexpected token categories are present.

The split is applied only to the relevant parsed AUTHOR tree, avoiding
changes to the general copyright grammar.

Changes

  • Detect individual authors in explicit multi-line contributor lists.
  • Add a regression fixture based on the reported govalidator case.
  • Update CHANGELOG.rst.
  • Add the contributor to AUTHORS.rst.

Testing

  • Regression fixture: 1 passed
  • Copyright detector suite: 4738 passed, 13 xfailed
  • End-to-end CLI scan: all 9 contributors detected separately
  • git diff --check: passed

The repository-wide standard suite was also run before the change on Windows.
It contains pre-existing environment/platform-related failures unrelated to
this patch.

Use lexer line numbers to create one author detection per contributor
when an explicit marker is followed by at least two name/contact lines.

Add a regression fixture for the govalidator contributor list.

Signed-off-by: Vaibhav Sharma <vs9109807@gmail.com>
Update the NVIDIA CUDA supplement license metadata to list its multiline authors separately, matching the author detections introduced for aboutcode-org#5138.

Signed-off-by: Vaibhav Sharma <vs9109807@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple contributors detected as single author

1 participant