Fix CheckboxGroup form reset with multiple selections - #10686
Open
Bhavani2016 wants to merge 1 commit into
Open
Bhavani2016 wants to merge 1 commit into
Bhavani2016 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10643
When a form resets a CheckboxGroup with multiple selected values, one checkbox can remain selected. The goal is for every checkbox to return to the group's default selection.
removeValue previously calculated each removal from the values captured by the render. When multiple removals happen in the same update, a later removal can restore a value removed earlier. This change uses a functional state update so each removal sees the latest values.
The change adds a React Aria Components regression test for both CheckboxField and Checkbox, plus a React Stately test for multiple removals in one update.
AI assistance disclosure: I used ChatGPT to help investigate the issue
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: