Repository navigation
GH-51687: [C++] Skipt tests that require threads if ARROW_ENABLE_THREADING=OFF - #51688
Merged
Merged
Conversation
Member
Author
|
@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The guards correctly cover all three affected tests and follow existing repository conventions.
Review effort: Balanced
Findings: None
What changed in this PR
Skips thread-dependent async generator tests when Arrow is built without threading support.
Changes:
- Adds
ARROW_ENABLE_THREADINGguards to three concurrency tests.
| File | Description |
|---|---|
cpp/src/arrow/util/async_generator_test.cc |
Skips tests that create threads when threading is disabled. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Revision: d9a22e0 Submitted crossbow builds: ursacomputing/crossbow @ actions-4481546a7e
|
zanmato1984
approved these changes
Oct 2, 2026
zanmato1984
left a comment
Contributor
There was a problem hiding this comment.
+1
Thanks for fixing this.
raulcd
added a commit
that referenced
this pull request
Oct 5, 2026
…ADING=OFF (#51688) ### Rationale for this change The following PR introduced some tests that require threeading but those are not skipped when ARROW_ENABLE_THREADING=OFF failing on jobs like emscripten. - #51498 ### What changes are included in this PR? Skip the tests if ARROW_ENABLE_THREADING=OFF ### Are these changes tested? Yes via archer with the failing job. ### Are there any user-facing changes? No ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [ ] AI **Reviewed before submission by:** - [x] Human - [ ] AI - [ ] Not reviewed * GitHub Issue: #51687 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The following PR introduced some tests that require threeading but those are not skipped when ARROW_ENABLE_THREADING=OFF failing on jobs like emscripten.
What changes are included in this PR?
Skip the tests if ARROW_ENABLE_THREADING=OFF
Are these changes tested?
Yes via archer with the failing job.
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: