Skip to content

ui: add the missing label for the backup resource limit #14163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stag7824 wants to merge 1 commit into
base: 4.22
Choose a base branch
from
Open

ui: add the missing label for the backup resource limit #14163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/public/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,6 +1540,7 @@
"label.max.primary.storage": "Max. primary (GiB)",
"label.max.secondary.storage": "Max. secondary (GiB)",
"label.max.migrations": "Max. migrations",
"label.maxbackup": "Max. Backups",
"label.maxbackups": "Max. Backups",
Comment on lines +1543 to 1544

@DaanHoogland DaanHoogland Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are now double. should we rename the reference instead?

@stag7824 stag7824 Oct 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both keys are built dynamically from different API names, so I don't think either can be renamed without breaking the other screen:

  • The Resource Limits tab builds label.max + the resource type name (ResourceLimitTab.vue:32), and for type 12 that name is backup, giving label.maxbackup.
  • The backup schedule list takes its columns from the fields array in storage.js ('maxbackups'), and AutogenView.vue turns each into label. + the field name, giving label.maxbackups.

Both backup and maxbackups come from the API response, so the keys follow them.

Snapshots already work the same way: label.maxsnaps (snapshot schedule field) and label.maxsnapshot (resource limit) both read "Max. Snapshots".

If you'd rather not have the duplicate, the alternative is to special-case backup in ResourceLimitTab.vue so it reuses label.maxbackups, but that adds code to avoid one string. Happy to do that if you prefer.

"label.maxbackupstorage": "Max. Backup Storage (GiB)",
"label.maxbackups.to.retain": "Max. Backups to retain",
Expand Down
Loading