Repository navigation
Conversation
|
@blueorangutan package |
|
@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4629 |
|
@soreana can you check build failures? I also see failing coverage and quality checks |
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 5042 |
|
@blueorangutan package |
|
@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 5145 |
|
@DaanHoogland Happy new year. :) |
|
@soreana I haven't had a chance to investigate very deeply yet, but at my laptop it also crashes with |
|
@DaanHoogland The |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@soreana i ran this in a debugger and for some reason your PR tries to load |
a37a4a5 to
833a7fd
Compare
|
@DaanHoogland I removed these lines and the build error gone. I don't know what was wrong. 🤷♂️ diff --git a/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java b/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java
index 33747b0342..6beba0b212 100644
--- a/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java
+++ b/server/src/test/java/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java
@@ -56,7 +56,6 @@ import com.cloud.network.dao.FirewallRulesDcidrsDaoImpl;
import com.cloud.network.dao.IPAddressDaoImpl;
import com.cloud.network.dao.LoadBalancerDao;
import com.cloud.network.dao.NetworkDao;
-import com.cloud.network.dao.NetworkDetailsDao;
import com.cloud.network.dao.NetworkDomainDaoImpl;
import com.cloud.network.dao.NetworkServiceMapDaoImpl;
import com.cloud.network.dao.PhysicalNetworkDaoImpl;
@@ -325,11 +324,6 @@ public class
return Mockito.mock(DomainDetailsDao.class);
}
- @Bean
- public NetworkDetailsDao networkDetailsDao() {
- return Mockito.mock(NetworkDetailsDao.class);
- }
-
@Bean
public DataStoreManager dataStoreManager() {
return Mockito.mock(DataStoreManager.class); |
|
@blueorangutan package |
|
@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5855 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6918 +/- ##
===========================================
Coverage 15.28% 15.28%
- Complexity 11528 11540 +12
===========================================
Files 5425 5425
Lines 474072 474259 +187
Branches 57689 61821 +4132
===========================================
+ Hits 72466 72511 +45
- Misses 393554 393675 +121
- Partials 8052 8073 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @soreana ! |
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9568 |
…oudstack into override-vr-service-offering
@weizhouapache It should be better now. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
hi @soreana please check / fix the conflicts in the branch. |
Hey @sureshanaparti, I don't have access to this repo any more. Please ask @benj-n to have a look. |
|
I am no longer have access to the LeaseWeb fork, I can't work continue this PR. I have tried to contact them, but I have not received a response. @phsm Feel free to reopen it or create another PR with these changes. |
Description
As of now, it is possible to override the virtual router service offering with global, domain, and account level configurations. What if a customer wants to change the service offering for only one network? There isn't such an option in Cloudstack. As an admin, you can only override the network offering for a domain, account, or global, affecting all the networks in that domain, account, or zone. This pull request aims to add a network-level setting to override the virtual router service offering per network.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
To test this feature, please follow the below steps:
network.router.service.offeringto the UUID of the service offering for the network using the cmkUseful
cmkcommands: