fix(compiler): rename C# union case colliding with generated Unknown member - #4106
Open
ayush00git wants to merge 2 commits into
Open
ayush00git wants to merge 2 commits into
ayush00git wants to merge 2 commits into
Conversation
…member Every generated C# union declares an Unknown(UnknownCase) member for the unknown-case fallback. A schema union case named "unknown" produced a second 'sealed partial record Unknown' in the same union, which fails to compile (CS0102). Rename such a case record to UnknownValue; case identity is the ForyCase number, so the rename does not affect wire behavior. Claude-Session: https://claude.ai/code/session_01YcPbRyTJYmU8t6mkGCbnUf
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The C# generator declares an
Unknown(UnknownCase)member in every generated union for the unknown-case fallback. A schema union case namedunknownproduced a secondsealed partial record Unknownin the same union, so the generated file failed to compile (CS0102 duplicate member):This renames such a case record to
UnknownValue, following the existingValue-suffix convention used for field/nested-type collisions. Case identity on the wire is theForyCasenumber, so the rename does not change wire behavior.Checklist
test_union_unknown_case_renamedintest_csharp_generator.py; it fails without the generator change.