Repository navigation
Optimize tag index timeseries lookup - #18753
Merged
jt2594838 merged 3 commits intoSep 30, 2026
Merged
Conversation
jt2594838
approved these changes
Sep 29, 2026
jt2594838
left a comment
Contributor
There was a problem hiding this comment.
May add a performance comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
mvn test -pl iotdb-core/datanode -Dtest=TagManagerTest -DfailIfNoTests=false -Dcheckstyle.skip=truemvn spotless:apply -pl iotdb-core/datanodeManual performance UT
TagManagerPerformanceTest is skipped by default. Enable it in a normal Maven build with:
mvn test -pl iotdb-core/datanode -Dtest=TagManagerPerformanceTest -Diotdb.tag.index.perf.enabled=true -DfailIfNoTests=falseLocal index-lookup microbenchmark on Windows 11, Intel Core i9-13900H, and Java HotSpot 17.0.15. The legacy side reproduces the previous tag-value scan, sort, then path filter; the optimized side calls the current TagManager lookup. The test asserts identical ordered results. Values are medians of 5 rounds with 30 warmups: 10,000 distinct tag values (1 exact match), 2,000 candidate nodes (100 path matches), and 50,000 exact-lookup or 1,000 path-filter iterations per round.
Local validation: the default-disabled invocation skipped the benchmark as intended; the enabled test passed; TagManagerTest passed all 4 tests; Spotless and Checkstyle passed.
Build note: full DataNode Maven test-compile failed locally in unrelated main-source/generated fill and mode classes. For these measurements, the current TagManager.java and performance test were compiled with javac against cached 2.0.11 artifacts and run through JUnitCore. The numbers cover index lookup, not an end-to-end query.