Repository navigation
Saturate the epoch deadline below the unwinding sentinel - #14513
Merged
alexcrichton merged 1 commit intoOct 4, 2026
Merged
Conversation
`Store::set_epoch_deadline` computes `current_epoch + delta`. `delta` is a caller-provided `u64` with no documented upper bound, and `u64::MAX` is not a free value here: `new_epoch` returns the deadline to wasm as a `u64` and reserves exactly that value as its unwinding sentinel. So a caller passing `u64::MAX` after the epoch has advanced either overflows (debug panics; release wraps the deadline into the past, which interrupts immediately) or lands exactly on the sentinel, which trips `assertion failed: abi != T::SENTINEL` in `traphandlers.rs`. Saturate, then clamp below the sentinel, so a large `delta` keeps meaning "effectively never".
alexcrichton
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing u64::MAX to set_epoch_deadline should mean "never interrupt". The runtime already uses
that exact value for something else. In a debug build you get a crash. In a release build the
deadline lands in the past and interrupts right away.