Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14510.
When an
f16comparison is folded into a branch or select, AArch64 can emitfcmp hN, hMeven withhas_fp16disabled. This instruction requires Arm's half-precision floating-point arithmetic extension (FEAT_FP16), so these comparisons can trap on CPUs without that feature.This widens both operands to
f32in the shared comparison helper when FP16 is unavailable. The scalar f16-to-f32fcvtconversion does not require FEAT_FP16. This also allows standalonef16comparisons and zero-extended comparison results to use the same fallback.Adds precise-output tests for the generated comparisons, an encoding test for the conversion, and runtime tests covering NaNs, signed zeros, infinities, and subnormals. The runtime tests were run on Apple Silicon with
has_fp16enabled and disabled.