fix(resolution): production code never names a test suite's symbol - #2209
Merged
Merged
Conversation
A test suite is not linked into the program, so a name match from production code into one is coincidence - but only Strategy 3's receiver guess (#2171) ruled it out. Now no strategy's name match reaches a symbol in a test suite from a non-test file: a test source set (`src/test/`, `jvmTest/`), a `tests/` / `__tests__/` / `spec/` / `e2e/` directory, a `FooTest.kt` / `test_foo.py` / `foo.test.ts` / `foo_spec.rb` file. Test-support code a project ships - `testing/`, `fakes/`, `mocks/`, a `*-test` module - stays in reach, and `…Spec.java` (halo's `IndexSpecs`, okhttp's `ConnectionSpec`), `post-spec.ts` models and `useTests.ts` hooks are not test suites. typeorm -64 (`Record<K, V>` -> a test entity), okhttp -164 (117 sample `@Override` -> a test's nested `Override`), kotlinx.coroutines -318 (`import kotlinx.coroutines.*` onto one test file's package node), sttp -62, Exposed -92, halo 0, element-plus -36 (`isClient` -> a test's vueuse mock), excalidraw -10 (`actionManager.executeAction` -> the test `API` helper), tokio -30, trpc -36, AutoMapper -37, netbox -22, cats -21, mealie -10, pytest -8, Alamofire -7; zod, eShop, react-native-reusables unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A test suite isn't linked into the program, so a name match from production code into one is coincidence. Until now only Strategy 3's receiver guess (#2171) ruled that out. Now no strategy's name match reaches a symbol in a test suite from a non-test file.
A test suite here means:
src/test/,jvmTest/);tests/,__tests__/,spec/ore2e/directory;FooTest.kt,test_foo.py,foo.test.tsorfoo_spec.rbfile.Test-support code a project ships (
testing/,fakes/,mocks/, a*-testmodule) stays in reach.…Spec.javafiles (halo'sIndexSpecs, okhttp'sConnectionSpec),post-spec.tsmodels anduseTests.tshooks aren't treated as test suites.Measured (wasm, main vs fix; losses only)
import kotlinx.coroutines.*onto one test file's package node@Override→ a test's nestedOverrideStubRow.getObject,FixedClock.nowRecord<K, V>→ a test entityLazyMonad.flatMapisClient→ a test's vueuse mockactionManager.executeAction→ the testAPIhelperTest plan
__tests__/prod-to-test-suite.test.ts(fails on main;testing/support and test→test guards)🤖 Generated with Claude Code