Repository navigation
bundle: clearer errors for bundle (re)naming and first deploy - #7005
Draft
janniklasrose wants to merge 2 commits into
Draft
janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
Both messages concern the bundle's root path, which is derived from bundle.name: - Replace the opaque "lineage mismatch in state files" error with the likely cause (another bundle deployed to the same root path, or a redeploy from a different machine or checkout after a destroy) and how to resolve it. - On the first deploy to a root (no prior state), print a notice that a new, independent deployment is being created, so renaming a bundle - which changes the root path - reads as a new deployment. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 730d30f
Top 8 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The bundle's workspace root path is derived from
bundle.name. Two deploy-time situations around (re)naming a bundle produce confusing output today:lineage mismatch in state files, which gives no hint that another bundle is deployed at that root.already exists).What
lineage mismatch in state fileserror with an explanation of the likely cause (another bundle deployed to the same root path, or a redeploy from a different machine/checkout after a destroy) and the fix (bundle.name/workspace.root_path). The existingAvailable state files:detail is unchanged.Creating a new deployment of bundle "<name>" at <root_path>It's gated like the per-resource action lines, so
-q/-qqsilence it.Notes for review
bundle deploy/pipelines deploy.bundle/deploy/mlops-stacks: the vendored-template materialization/cleanup fails in this sandbox, so the deploy output didn't regenerate.bundle/deploy/immutable-permissions-change: regenerating reordered the non-deterministic per-resource lines; reverted that and added only the notice.This pull request and its description were written by Isaac.