Bump github.com/elazarl/goproxy from 1.9.0 to 1.9.1 - #271
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github.com/elazarl/goproxy](https://github.com/elazarl/goproxy) from 1.9.0 to 1.9.1. - [Release notes](https://github.com/elazarl/goproxy/releases) - [Commits](elazarl/goproxy@v1.9.0...v1.9.1) --- updated-dependencies: - dependency-name: github.com/elazarl/goproxy dependency-version: 1.9.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
jeffwidman
reviewed
Oct 1, 2026
jeffwidman
left a comment
Member
There was a problem hiding this comment.
The Build failure is a deterministic compatibility regression from goproxy 1.9.1, specifically elazarl/goproxy#799. For HTTPS requests inside a CONNECT tunnel, it now reconstructs req.URL using the inner Host header instead of the original CONNECT destination. This proxy relies on req.URL.Host retaining the actual destination while the potentially spoofed req.Host is normalized and checked separately.
As a result:
- Requests to
metadata.google.internalwith innerHost: example.combypass the metadata block: both:443and:8443cases expected 403 but received 404. - A local request with inner
Host: api.dependabot.exampleis routed to that hostname, fails DNS lookup, and returns EOF. - A local request with inner
Host: metadata.google.internalis incorrectly blocked with 403 instead of reaching the local upstream with 200.
A rerun will not resolve this. This should remain on 1.9.0 unless the proxy is changed to preserve and validate the CONNECT destination independently of the inner Host header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/elazarl/goproxy from 1.9.0 to 1.9.1.
Release notes
Sourced from github.com/elazarl/goproxy's releases.
Commits
e540bd6fix(mitm): never frame bodiless responses as chunked (#797)2b17647Echo client HTTP version in CONNECT tunnel reply (#802) (#804)4c85e93Fix: normalize req.URL.Host in MITM by prioritizing inner Host header (#799)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)