Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered and no blocking issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Adds llama.cpp reasoning-preservation flags to runtime validation, enabling reasoning trace retention for prompt/KV cache reuse.
Changes:
- Allowlists
--reasoning-preserveand--no-reasoning-preserve. - Adds validation and category test coverage.
| File | Description |
|---|---|
pkg/inference/runtime_flags_test.go |
Tests runtime validation for both flags. |
pkg/inference/runtime_flags_allowlist.go |
Adds the two flags to the llama.cpp allowlist. |
pkg/inference/runtime_flags_allowlist_test.go |
Covers reasoning-category membership. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Good addition, but it now conflicts with main since #1065 touched the same allowlist map. Please rebase, nothing else to fix. Also, model-runner is being deprecated in favor of llmman, please open future PRs there instead. Marking as draft, please mark ready for review once rebased. |
This PR adds
--reasoning-preserveand--no-reasoning-preserveto thellama.cppruntime flag allowlist.These flags are supported by
llama.cppand are boolean-only options. They do not access files or external resources, so they fit the existing security model used for runtime flag validation.--reasoning-preserveis important for reasoning models because it keeps the reasoning trace in the conversation history, allowing prompt/KV cache reuse when combined with prompt caching.Without this change, Docker Model Runner rejects the flags before
llama.cppis started.