fix(cli): remove unused backend flag from compose up - #1037
VedantMadane wants to merge 2 commits into
Conversation
|
Hello @VedantMadane, I need to look into why this is here. Indeed |
42f4b20 to
14f5ade
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Regenerate and commit the reference documentation so it no longer advertises the removed flag.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Removes the unused --backend option from docker model compose up.
Changes:
- Removes the dead flag, binding, and unused
llamacppimport. - Reference documentation still requires regeneration to remove the obsolete option.
| File | Description |
|---|---|
cmd/cli/commands/compose.go |
Removes the unused backend flag and import. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -127,7 +125,6 @@ func newUpCommand() *cobra.Command { | |||
| c.Flags().StringArrayVar(&models, "model", nil, "model to use") | |||
| c.Flags().Int64Var(&ctxSize, "context-size", -1, "context size for the model") | |||
| c.Flags().StringVar(&rawRuntimeFlags, "runtime-flags", "", "raw runtime flags to pass to the inference engine") | |||
Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
|
Change itself is clean, but doringeman flagged that the right fix might be wiring the flag instead of removing it, that's still unresolved, and CI hasn't run on this yet. Please get maintainer agreement on the approach and a green CI run. Also, model-runner is being deprecated in favor of llmman, please open future PRs there instead. Marking as draft, please mark ready for review once addressed. |
|
Understood, thank you @ericcurtin and @doringeman. If the plan is to wire --backend\ through Compose instead, or given the deprecation in favor of \llmman, please let me know how you would prefer to proceed here or if we should close this in favor of \llmman. |
Summary
Fixes #1036
In cmd/cli/commands/compose.go,
ewUpCommand() defined a --backend flag variable �ackend but never passed it to desktopClient.ConfigureBackend(...). As a result, passing --backend was a silent no-op while compose metadata still advertised --backend parameter to UI consumers.
This PR removes the dead --backend flag variable and flag binding from
ewUpCommand() and removes the unused llamacpp import.