Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(windows): add Vulkan GPU detection for Intel Arc and other non-CUDA GPUs #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(windows): add Vulkan GPU detection for Intel Arc and other non-CUDA GPUs #930
Changes from all commits
4ca4ba4d652be9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if we're not planning to use this func in other places, i think we could inline its logic into
hasVulkan()since this func here isn't actually checking for vulkan capable GPUs (which would include nvidia and others potentially).the check described by this func name is only truly complete when
hasVulkan()itself has run the rest of its code.Also, given the switch case defining the
desiredVariantin download_windows.go, we could probably even remove the checks for nvidia and adreno from here, unless we truly prefer to try and use OpenCL over Vulkan on those GPUs (for nvidia it'd be relevant only if for whatever reason the check if the gpu can use CUDA11 fails).Thoughts on this @ericcurtin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vulkan would be well down the list of priorities
CUDA -> ROCm -> OpenVino -> Vulkan
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.