Skip to content

adding a CONTRIBUTING.md file - #868

Closed
Amrit-raj50 wants to merge 9 commits into
git:masterfrom
Amrit-raj50:add-contributing-md
Closed

Amrit-raj50 wants to merge 9 commits into
git:masterfrom
Amrit-raj50:add-contributing-md

Conversation

@Amrit-raj50

@Amrit-raj50 Amrit-raj50 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds a CONTRIBUTING.md file to the repository.

GitHub automatically surfaces this file to anyone who opens a new
issue or pull request, helping new contributors understand how to
participate before they submit anything.

The file covers:

  • Ways to contribute (typos, content, newsletter, infrastructure)
  • Submitting changes via Pull Request (step-by-step)
  • Submitting changes via email patch (with maintainer contacts)
  • Running the site locally (Jekyll setup)
  • Writing guidelines (Markdown style, code fences)
  • Code style notes (JS, CSS, Gemfile, whitespace)
  • Git Rev News newsletter contribution process
  • Reporting issues (what to include in a bug report)

All information is based on the existing README.md and repository
conventions — nothing new is introduced, just consolidated in one
place for contributor discoverability.

Closes/Relates to: (add issue number if one exists)

issue : #864

@Amrit-raj50

Copy link
Copy Markdown
Contributor Author

@chriscool @sivaraam — Could you take a look at this when you get
a chance?

Comment thread CONTRIBUTING.md Outdated
@@ -0,0 +1,144 @@
# Contributing to Git Developer Pages

Thank you for your interest in contributing to [git.github.io](https://git.github.io) — the community website for Git development, home to the [Git Rev News newsletter](https://git.github.io/rev_news/), [Hacking Git](https://git.github.io/Hacking-Git/), and mentoring program information.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid long lines like this. Instead please split them at around 72 characters.

Also please avoid — characters. It looks too much AI generated.

Comment thread CONTRIBUTING.md
---

## Ways to Contribute

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an introduction sentence, like "In general we accept all kind of contributions to all the pages on this website, but here are some suggestions along with a few guidelines:"

Comment thread CONTRIBUTING.md Outdated

## Ways to Contribute

- Fix typos, broken links, or outdated information

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those kinds of contributions are fine for all the website except already published editions of Git Rev News. I don't think we want to fix things in old editions.

@jnareb, @mjaix and @sivaraam do you have an opinion on this?

Comment thread CONTRIBUTING.md Outdated
## Ways to Contribute

- Fix typos, broken links, or outdated information
- Improve or add pages under `links/`, `rev_news/`, or other sections

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure listing those directories make sense. I think it would make more sense to list the section on the website instead.

Comment thread CONTRIBUTING.md Outdated

- Fix typos, broken links, or outdated information
- Improve or add pages under `links/`, `rev_news/`, or other sections
- Add entries to the Git Rev News newsletter

@chriscool chriscool Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what "entries" means here. I think this should be more detailed. It should say what could be added in which section, how to find the upcoming edition where things can be added, and so on.

Comment thread CONTRIBUTING.md Outdated
- Fix typos, broken links, or outdated information
- Improve or add pages under `links/`, `rev_news/`, or other sections
- Add entries to the Git Rev News newsletter
- Improve site infrastructure (CSS, JavaScript, Jekyll layouts/plugins)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any big improvement, people should look at existing issues and if needed create a new one before starting to work.

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
git checkout -b my-fix
```
4. **Make your changes**, following the [Writing Guidelines](#writing-guidelines) below.
5. **Test locally** by [running the site](#running-the-site-locally) and verifying your changes look correct.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to test their changes locally when contributing to a Git Rev News edition.

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
@chriscool

Copy link
Copy Markdown
Collaborator

@Amrit-raj50 I have left a number of comments. Thanks.

@Amrit-raj50

Copy link
Copy Markdown
Contributor Author

I will raise the new PR for this after thrusday

Comment thread CONTRIBUTING.md Outdated

- Fix typos, broken links, or outdated information across the site
(except for already published editions of Git Rev News, which are
kept as historical archives).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible open a Pull Request (PR) to submit your changes.

Comment thread CONTRIBUTING.md Outdated
(except for already published editions of Git Rev News, which are
kept as historical archives).
- Improve or add content to sections of the website such as the
Links page, Mentoring pages, or general documentation.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also, they might want to open a PR for this.

Comment thread CONTRIBUTING.md Outdated
plugins). Before starting work on major improvements, please check
existing issues and open a new issue for discussion first.
- Participate in community discussions by sharing opinions on open
issues or reviewing open Pull Requests.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have links to our open Issues and PRs.

Comment thread CONTRIBUTING.md Outdated
newsletter (see [below](#git-rev-news-newsletter)).
- Improve site infrastructure (CSS, JavaScript, Jekyll layouts, or
plugins). Before starting work on major improvements, please check
existing issues and open a new issue for discussion first.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have links to our open Issues.

Comment thread CONTRIBUTING.md Outdated
below.
5. **Test locally** if needed by [running the site](#running-the-site-locally)
and verifying your changes look correct. (Note: this is not required
for newsletter contributions.)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also not required for small things like typofixes.

Comment thread CONTRIBUTING.md Outdated

Note: Running the site locally is helpful when working on layouts,
styles, or general pages, but it is **not required** when submitting
content for Git Rev News editions.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required also when sending typofixes or similar small changes.

Comment thread CONTRIBUTING.md Outdated
### How to Contribute Content

Each upcoming edition is prepared in advance as a Markdown file under
`_posts/` (e.g. `_posts/YYYY-MM-DD-edition-XXX.markdown`).

@chriscool chriscool Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before being published, an edition is prepared under rev_news/drafts/, for example right now edition 139 is at: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-139.md

But when an edition is published, its file is moved under _posts/ and renamed, for example: edition 138 is at: https://github.com/git/git.github.io/blob/master/_posts/2026-08-31-edition-138.markdown

Comment thread CONTRIBUTING.md Outdated

You can contribute in several ways:
- **Share entries in the edition issue:** A dedicated GitHub Issue is
opened for every upcoming edition (titled e.g. "Git Rev News Edition

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is actually "Any comment about upcoming Git Rev News edition XXX" where XXX is the edition number, for example see: #860

Comment thread CONTRIBUTING.md Outdated
XXX"). You can comment directly on that issue with links, articles,
tools, or news you would like included.
- **Submit a Pull Request:** Add your entry directly to the draft file
under `_posts/` for the upcoming edition. Common entries include:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the draft file is not under _posts/, but rather under rev_news/drafts/

@chriscool

Copy link
Copy Markdown
Collaborator

Thanks @Amrit-raj50, it's looking much better. I have commented on a few things that could still be improved though.

@Amrit-raj50

Amrit-raj50 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @chriscool ,
PR #868
check this latest PR where i have applied all the asked changes

and please help me with #865, so that i can start working on it .

@chriscool

Copy link
Copy Markdown
Collaborator

The changes to the new CONTRIBUTING.md file look good to me, but I am not sure why there are changes to the script/prism.js file in this PR. Do the changes to that script/prism.js file really need to be in this PR? Couldn't they be in their own PR?

Also it would be nice if all the commits in the PR were squashed together and if there were no merge commits in this PR. Only a single commit adding CONTRIBUTING.md please.

@chriscool

chriscool commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Hi @chriscool , PR #868 check this latest PR where i have applied all the asked changes

and please help me with #865, so that i can start working on it .

Actually both PRs contain the same 9 commits. #868 was created from your master branch (the head branch of #865), and the CONTRIBUTING.md commits were then pushed to master too, so #865 now also adds CONTRIBUTING.md.

Please:

  • Don't open PRs from your master branch.
  • Create a new branch for each PR.
  • A single commit on each branch (and each PR) should be enough.

It might actually be better to close both PRs and to start new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants