GitPython wheel includes "py2" in filename, but doesn't support Python 2 #898

Activity

1. olivierlefloch commented on Jul 23, 2019

   

   olivierlefloch

   on Jul 23, 2019

   Last edited by olivierlefloch

   More actions

   2.1.12 specifies

   Requires-Python: >=3.0, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*
   

   2.1.11 specifies

   Requires-Python: >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*
   

   The changelog however does not mention removal of 2.7 support:

   https://github.com/gitpython-developers/GitPython/blob/master/doc/source/changes.rst#2112---bugfixes-and-features

   Python 2.7 support was dropped in #312

   Perhaps doing this in a patch version was a bit heavy handed?
2. stsewd commented on Jul 27, 2019

   

   stsewd

   on Jul 27, 2019

   Contributor

   More actions

   BTW, python 2 support was kind of dropped in 2.1.11 7f08b77#diff-c276fc3c4df38382ec884e59657b869dR125 (when using a unicode branch/tag name that will fail)
3. Byron commented on Jul 29, 2019

   

   Byron

   on Jul 29, 2019

   Member

   More actions

   @olivierlefloch I absolutely agree, and apologies, and I have just released v2.1.13 which returns python 2 support.

   I am trying to cut a new release v3.0.0 which removes python 2 support, if I can manage to figure out all the places to edit to make that happen. For now I don't know how to turn off the py2. part in the whl filename, but I will keep trying 😅.

   👍React with 👍1Reacted by Santos Gallegos
4. Byron

   added

   acknowledged

   on Jul 29, 2019
5. Byron

   self-assigned this

   on Jul 29, 2019
6. dstine commented on Jul 29, 2019

   

   dstine

   on Jul 29, 2019

   More actions

   @Byron
   I did a quick experiment on the tip of master, and it appears that if you update setup.cfg to

   [bdist_wheel]
   universal=0
   

   then the python tag will be just py3 instead of py2.py3 and the resulting wheel filename is GitPython-2.1.13-py3-none-any.whl. Assuming you are building with Python 3.

   You would still want to update setup.py as you did before, to change python_requires and classifiers.
7. ghost added a commit that references this issue on Aug 11, 2019

   Avoid creating python 2 release

   ...

   acbd5c0
8. Byron

   added this to the v3.0.0 - Remove Python 2 milestone on Aug 11, 2019
9. Byron commented on Aug 11, 2019

   

   Byron

   on Aug 11, 2019

   Member

   More actions

   Perfect, this works. Thanks so much, @dstine

   👍React with 👍1Reacted by Dan Stine
10. Byron

    closed this as completedon Aug 11, 2019