fix(storage): support download stall timeout in async BiDi reads - #16418
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces timeout handling to the asynchronous OpenObject RPC stream by wrapping the underlying RPC with AsyncStreamingReadWriteRpcTimeout using a scaled stall timeout, and adds a corresponding unit test to verify timeout cancellation. The review feedback suggests replacing several usages of auto with explicit types (for timeout, rpc, pending, and response) to adhere to the repository's style guide against obscuring domain and return types.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16418 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 2246 2246
Lines 212584 212648 +64
=======================================
+ Hits 196175 196237 +62
- Misses 16409 16411 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rajeevpodar
reviewed
Sep 9, 2026
rajeevpodar
requested changes
Sep 9, 2026
rajeevpodar
approved these changes
Sep 9, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening an async bidirectional read stream (
AsyncBidiReadObject), a network stall or silent disconnect during the initial stream handshake (Start,Write, or initialRead) can cause the call to hang indefinitely.This PR does the following:
AsyncBidiReadObjectstreaming RPC withAsyncStreamingReadWriteRpcTimeoutinOpenObject::Call().DownloadStallTimeoutOptionorTransferStallTimeoutOption, setting the expected chunk size toServiceConstants::MAX_READ_CHUNK_BYTES(2 MiB).open_object_test.ccverifying watchdog timer scheduling, reset on progress, and stream cancellation on timeout.