ci(bun): enable real Bun runtime unit tests for packages and core - #9396
Merged
Merged
Conversation
quirogas
added this pull request to stack #9397
September 21, 2026 16:02
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the conditional test runner script ci/run_conditional_tests.sh to support the Bun runtime. It adjusts the target subdirectories, skips internal CLI tools on Bun, and triggers unit tests for core packages. The review feedback recommends normalizing directory paths by stripping trailing slashes to prevent comparison failures and removing unnecessary subshell parentheses in the conditional logic to avoid overhead.
quirogas
removed this pull request from stack #9397
September 21, 2026 23:32
quirogas
added this pull request to stack #9404
September 21, 2026 23:33
quirogas
force-pushed
the
bun-runtime/4-ci-workflow
branch
3 times, most recently
from
September 23, 2026 16:06
88e6f33 to
bf93d62
Compare
quirogas
force-pushed
the
bun-runtime/4-ci-workflow
branch
from
September 28, 2026 23:07
bf93d62 to
1503dea
Compare
Updates .github/workflows/presubmit-bun.yml and ci/run_conditional_tests.sh to execute unit tests on the Bun 1.4.2 runtime across packages/* and core/packages/*. Renames the job and status checks to bun-units / Bun (1.4.2) without Node version matrix duplication, sets TEST_CMD to 'bun --bun run' with JS_RUNTIME=bun and MOCHA_PARALLEL=false, and scopes Bun CI execution to packages/* and core/packages/*.
quirogas
force-pushed
the
bun-runtime/4-ci-workflow
branch
from
September 29, 2026 15:09
1503dea to
8b04f59
Compare
…d Headers in Bun shim
danieljbruce
approved these changes
Sep 30, 2026
danieljbruce
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Some optional comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
.github/workflows/presubmit-bun.ymlworkflow has a few problems that prevent it from properly testing libraries on Bun:node-unitsandNode (22, shard N)), which is misleading because the workflow runs Bun rather than Node.js.TEST_CMD: "bun --bun", which causesci/run_single_test.shto runbun --bun test(Bun's built-in test runner) instead ofbun --bun run test(the package's"test"script).ci/run_conditional_tests.shskipscore/packages/*and does not scope Bun test runs exclusively topackages/*andcore/packages/*.This PR updates
.github/workflows/presubmit-bun.ymlto use clear Bun job names (bun-units,Bun (1.4.2, shard N), andBun (1.4.2)) and setsTEST_CMD: "bun --bun run"withJS_RUNTIME: "bun"across 8 parallel shards. It also updatesci/run_conditional_tests.shso that whenJS_RUNTIMEis set tobun, CI runs unit tests specifically forpackages/*andcore/packages/*(skippinghandwritten/*,core/dev-packages/*, and internal repo CLI tools).