feat(gax): enable telemetry tracing via client options without internalTelemetryInfo - #9476
Draft
shivanee-p wants to merge 1 commit into
Draft
shivanee-p wants to merge 1 commit into
shivanee-p wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the telemetry tracing enablement check in core/packages/gax/src/util.ts by removing the requirement for internalTelemetryInfo to be defined. Now, checkTelemetryEnabled only checks if enableTelemetryTracing is set on the settings or other arguments. The JSDoc comments and unit tests have been updated accordingly to reflect this change. There are no review comments to address.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates checkTelemetryEnabled to allow enabling telemetry tracing via client settings (enableTelemetryTracing or otherArgs.enableTelemetryTracing) without requiring compile-time internalTelemetryInfo metadata.