Repository navigation
feat(auth): wire gRPC mTLS cert rotation into secure_authorized_channel - #18557
Open
agrawalradhika-cell wants to merge 4 commits into
Open
agrawalradhika-cell wants to merge 4 commits into
agrawalradhika-cell wants to merge 4 commits into
Conversation
… gRPC mTLS Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces automatic mTLS certificate rotation and channel refreshing for gRPC transports. It adds a new mtls_interceptor.py module containing CertRotationInterceptor and MTLSRefreshingChannel to intercept and retry failed calls on UNAUTHENTICATED errors, and updates _mtls_helper.py to decrypt passphrase-protected private keys. Feedback on these changes suggests ensuring that registered done callbacks are triggered when refresh_logic fails to prevent downstream callers from hanging, and fully implementing the grpc.Call interface in _DeadlineExceededError to avoid potential AttributeError exceptions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 2 splitting #18019.
Stacked on top of #18556.
This PR wires
CertRotationInterceptorandMTLSRefreshingChannelintogoogle.auth.transport.grpc.secure_authorized_channelwhen an mTLS client certificate is configured, and updatesgoogle.auth.transport._mtls_helper.call_client_cert_callbackto decrypt passphrase-protected private keys before returning(cert_bytes, key_bytes).See go/grpc-cert-rotation-in-pythonsdk-for-x509 for details.
Pre-review checklist
go/author-standard).b/):