Repository navigation
Explicitly set annotation processor for JDK23+ compatibility - #4935
Conversation
|
Welcome @thebeanogamer! |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The processor path must retain the existing com.sun:tools exclusion for modern JDK compatibility.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Explicitly configures Sundr annotation processing for JDK 23+ compatibility.
Changes:
- Adds
builder-annotationsto Maven’s annotation processor path.
| File | Description |
|---|---|
fluent-gen/pom.xml |
Configures the fluent generator’s annotation processor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
/lgtm Thanks for digging into this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, thebeanogamer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |

When running the generator locally it was silently failing because my local JDK is JDK 25. As far as I can tell, this is the correct way to tell Java to let the annotation processor run.
Context: https://maven.apache.org/plugins/maven-compiler-plugin-4.x/examples/annotation-processor.html