Skip to content

Explicitly set annotation processor for JDK23+ compatibility - #4935

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-client:masterfrom
thebeanogamer:master
Oct 6, 2026
Merged

kubernetes-prow[bot] merged 2 commits into
kubernetes-client:masterfrom
thebeanogamer:master

Conversation

@thebeanogamer

Copy link
Copy Markdown
Contributor

When running the generator locally it was silently failing because my local JDK is JDK 25. As far as I can tell, this is the correct way to tell Java to let the annotation processor run.

Context: https://maven.apache.org/plugins/maven-compiler-plugin-4.x/examples/annotation-processor.html

Copilot AI balanced review requested due to automatic review settings October 6, 2026 14:10
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 6, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @thebeanogamer!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The processor path must retain the existing com.sun:tools exclusion for modern JDK compatibility.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Explicitly configures Sundr annotation processing for JDK 23+ compatibility.

Changes:

  • Adds builder-annotations to Maven’s annotation processor path.
File Description
fluent-gen/​pom.xml Configures the fluent generator’s annotation processor.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread fluent-gen/pom.xml
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2026
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 6, 2026
@brendandburns

Copy link
Copy Markdown
Contributor

/lgtm
/approve

Thanks for digging into this.

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, thebeanogamer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 6f54134 into kubernetes-client:master Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants