Azure Core VNext and ClientCore updates - #7115
Merged
Merged
Conversation
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
Weidong Xu (weidongxu-microsoft)
approved these changes
Apr 27, 2025
Contributor
There was a problem hiding this comment.
Unblock.
There are a few things I have concern
- clientcore tests are disabled. It seems either the codegen or annotation processor have major problem (otherwise I'd expect just disabling a few test cases)
- There be 1.0.0 compiler release at about May 4, we would likely need to release a working unbranded emitter on this version
- We can merge this, and keep release unbranded emitter from feature branch on clientcore beta.5 for a few releases. But we'd expect the new clientcore work before long, as such release from branch would have large Eng cost (and likely would eventually fail when it diffs too much from main)
- Code around ClientMethod(Mapper/Template) have potentially large duplications. I'd hope we know what's the diff between the baseclass and subclass, so that is be possible to reduce the duplication in future.
- Turn of
convenienceAPIwould be a concern #7115 (comment) - We want to avoid generating
@Generatedin mgmt #7115 (comment) (for now)
Anu Thomas (anuchandy)
approved these changes
May 6, 2025
Srikanta (srnagar)
enabled auto-merge
May 6, 2025 08:12
Timothee Guerin (timotheeguerin)
approved these changes
May 6, 2025
Anu Thomas (anuchandy)
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.