Repository navigation
build: --without-ssl and --without-intl imply new limitation (no debugger) #12758
Description
Activity
Marked regression since when node8 is built
--without-sslit will not have any kind of debugger interface. and this a new regressive behaviour for the--without-sslswitchReacted by Anna Henningsencould we build a proxy?
I thought about it, and then again, since this is an unintended consequence of the
--without-sslswitch, IMHO even a strongly worded warning would solve this issue.@addaleax you are right in that this not an
inspectorbug but IMHO it is abuildregression.- changed the title
[-]inspector: unavailable when built --without-ssl[/-][+]build: --without-ssl has unintended consequences (no debugger) [/+]on Apr 30, 2017 Doesn't sound like a bug to me. Lots of stuff disappears when SSL isn't built in (crypto, https, ...). Building without OpenSSL is a fringe build, for special purposes.
Doesn't sound like a bug to me. Lots of stuff disappears when SSL isn't built in (crypto, https, ...). Building without OpenSSL is a fringe build, for special purposes.
This is a regression in the build behaviour, since it's a new consequence of a feature that disappears.
My solution was just to require explicitly to configure--without-debugger#12768@refack I don't really follow, sorry.
Are you saying that
--without-sslused to build node with the Inspector, and now it doesn't?Or are you saying that
--without-ssldisables the Inspector and leave the Debugger so node could be generally said to "support debugging", and now that there is no Debugger, node can generally be said to "not support debugging"?Or are you saying that
--without-ssldisables the Inspector and leave the Debugger so node could be generally said to "support debugging", and now that there is no Debugger, node can generally be said to "not support debugging"?Yes.
i.e. if you build v7--without-sslyou can still debug, but ever since #12197 if you build--without-sslyou have no debugger interface (neitherdebugorinspectprotocols). That's a new loss of an ability.My proposed solution is to require the builder to additionally explicitly specify
--without-debugger(or--without-inspector) when calling./configure- changed the title
[-]build: --without-ssl has unintended consequences (no debugger) [/-][+]build: --without-ssl and --without-intl imply new limitation (no debugger)[/+]on May 8, 2017 Apparently
--without-intlhas the same effect. Title and first comment updated.I don't see the regression. Losing the Debugger is obviously backwards incompatible/semver-major (and was treated as such). Also, forcing people to type two flags instead of one is an annoyance rather than being helpful.
Unless you are saying that its possible to not have SSL, but to have the Inspector? You are decoupling that? If not, I'm not sure what problem is being solved here.
Unless you are saying that it's possible to not have SSL, but to have the Inspector? You are decoupling that? If not, I'm not sure what problem is being solved here.
I was hoping that's possible. And I'm looking into it, but that's a bigger issue.
Also, forcing people to type two flags instead of one is an annoyance rather than being helpful.
IMHO building a new (even semver-major) version and finding out you lost a previously available (important) ability, without any warning, is worse.
I see it a bit like theexperimental(#12723) discussion. The user should explicitly opt-in to new behaviour, that way we minimize surprises.Another solution would be to emit a warning, but I fear it'll be drowned in all sort of script outputs.
There was a fair amount of warning that the Debugger was going away. And since there is no way to opt-out of the new behaviour, talking about opt-in vs opt-out doesn't seem to apply. And failing to disable SSL when configuring explicitly
--without-sslis in itself a step backwards and a loss of a feature. IMO, the pain exceeds the arguable gain.Is there any reason why
--without-intldisable debugger?@sparkleholic
--without-intldisables ICU. The debugger uses ICU.
Since #12197 (i.e. node8) when
nodeis built--without-sslor--without-intlinspector is not available. As a consequence node is built with no debugger interface.configuredoes not warn about this (new) consequence.Since in previous versions these switches did not remove all debugger interface, this is a regression in the build behaviour.
Ref: #12757