Exception after "break on start" causes hard crash #13438

Activity

1. seishun

   added

   v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.

   debugger

   on Jun 3, 2017
2. alex7kom commented on Jun 3, 2017

   

   alex7kom

   on Jun 3, 2017

   More actions

   I've reproduced this on macOS 10.12.5

   Debugger listening on ws://127.0.0.1:9229/2ed98bf7-17e4-4355-be86-7fa24cd2b63c
   For help see https://nodejs.org/en/docs/inspector
   Debugger attached.
   FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
    1: node::Abort() [/Users/alex7kom/.nvm/versions/node/v8.0.0/bin/node]
    2: node::FatalException(v8::Isolate*, v8::Local<v8::Value>, v8::Local<v8::Message>) [/Users/alex7kom/.nvm/versions/node/v8.0.0/bin/node]
    3: v8::V8::ToLocalEmpty() [/Users/alex7kom/.nvm/versions/node/v8.0.0/bin/node]
    4: node::inspector::(anonymous namespace)::CallAndPauseOnStart(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/alex7kom/.nvm/versions/node/v8.0.0/bin/node]
    5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/Users/alex7kom/.nvm/versions/node/v8.0.0/bin/node]
    6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/alex7kom/.nvm/versions/node/v8.0.0/bin/node]
    7: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/alex7kom/.nvm/versions/node/v8.0.0/bin/node]
    8: 0x873b248437d
    9: 0x873b2650969
   10: 0x873b264a823
   [1]    15343 abort      node --inspect-brk debug.js
   

   👍React with 👍1Reacted by Nikolai Vavilov
3. bnoordhuis

   added

   inspectorIssues and PRs related to the V8 inspector protocol.Issues and PRs related to the V8 inspector protocol.

   on Jun 3, 2017
4. seishun commented on Jun 4, 2017

   

   seishun

   on Jun 4, 2017

   ContributorAuthor

   More actions

   When breaking on start, this code is executed:

   node/lib/module.js

   Lines 566 to 567 in 16689e3

   	result = inspectorWrapper(compiledWrapper, this.exports, this.exports,
   	require, this, filename, dirname);

   Which in turn calls this:

   node/src/inspector_agent.cc

   Lines 360 to 375 in 26ab769

   	void CallAndPauseOnStart(
   	const v8::FunctionCallbackInfo<v8::Value>& args) {
   	Environment* env = Environment::GetCurrent(args);
   	CHECK_GT(args.Length(), 1);
   	CHECK(args[0]->IsFunction());
   	std::vector<v8::Local<v8::Value>> call_args;
   	for (int i = 2; i < args.Length(); i++) {
   	call_args.push_back(args[i]);
   	}
   	env->inspector_agent()->PauseOnNextJavascriptStatement("Break on start");
   	v8::MaybeLocal<v8::Value> retval =
   	args[0].As<v8::Function>()->Call(env->context(), args[1],
   	call_args.size(), call_args.data());
   	args.GetReturnValue().Set(retval.ToLocalChecked());
   	}

   But it apparently doesn't handle exceptions.

   This code was introduced in 7954d2a (#12076). cc @eugeneo
5. seishun

   changed the title [-]Requiring non-existent module while in debugger hard crashes[/-] [+]Exception after "break on start" causes hard crash[/+] on Jun 4, 2017
6. seishun

   closed this as completedin #13455on Jun 9, 2017
7. addaleax

   added a commit that references this issue on Jun 10, 2017

   inspector: fix crash on exception

   ...

   6a696d1