build: there are two bench phony targets in the makefile

What the title says. One of them should be removed.

Lines 1121 to 1122 in c5a49e1

    
           bench \ 
        
           bench \

Not really a bug. Multiple .PHONY targets are allowed and even encouraged by some style guides.

Since we're discussing this, maybe it's a good idea to switch to this style:

.PHONY: foo
foo:
        make_foo

.PHONY: bar
bar:
        make_bar

Makes it more obvious it's phony vis-a-vis hiding that fact at the end of the file.

Added good first issue label for Ben's suggestion.

@targos

Hello @targos, @bnoordhuis
Should we make it like:

.PHONY: foo
foo:
        make_foo

.PHONY: bar
bar:
        make_bar

# Redefinition
.PHONY: foo \
  bar

Maybe I can work on this

@okyantoro Yes, but not the block you labeled 'redefinition.'

@bnoordhuis

@bnoordhuis I am still working on this. But I find targets below have no matching target inside Makefile.

bench-http-simple \
  bench-idle \
  blog \
  blogclean \
  dist \
  dynamiclib \
  install-bin \
  install-includes \
  staticlib \
  website-upload

Is it okay to delete these targets?

@okyantoro Yes, that's fine.

build: put .PHONY on line before of its target definition.

build: put .PHONY directly before its target

Fixed in #17964
Thank you @okyantoro !

build: put .PHONY directly before its target

Navigation Menu