Nested HTTP/2 pushStream fails with error

Version: 9.7.1
Platform: 64-bit (Windows)
Subsystem: http/2

//server = http2.createSecureServer(); init code removed for brevity
server.addListener('stream', function (stream, headers) {
    let resourcePath = path.join(serverRootPath, headers[HTTP2_HEADER_PATH]);
    stream.respondWithFile(resourcePath, {
        'content-type': mimeTypes.get(resourcePath.match(mimeRegExp)[0]),
    });
    let pushResourcePath = <full path to pushed resource>;
    stream.pushStream({ ':path': pushResourcePath }, { 'parent': stream.id }, (err, stream, headers) => {
        stream.respondWithFile(path.join(serverRoot, pushResourcePath), {
            'content-type': mimeTypes.get(path.join(serverRoot, pushResourcePath).match(mimeRegExp)[0]),
        });
        let subPushResourcePath = <full path to sub pushed resource>;
        stream.pushStream({ ':path': subPushResourcePath }, { 'parent': stream.id }, (err, stream, headers) => {
            stream.respondWithFile(path.join(serverRoot, subPushResourcePath), {
                'content-type': mimeTypes.get(path.join(serverRoot, subPushResourcePath).match(mimeRegExp)[0]),
            });
        });
    });
});

The nested pushStream callback argument (err) is populated with this:

{ Error [ERR_HTTP2_ERROR]: Invalid argument
at ServerHttp2Stream.pushStream (internal/http2/core.js:2095:17)
at file:///D:/http2_experimental_server/src/server.mjs:106:24
at process._tickCallback (internal/process/next_tick.js:114:19)
code: 'ERR_HTTP2_ERROR',
name: 'Error [ERR_HTTP2_ERROR]',
errno: -501 }

A push stream cannot be the parent of another push stream. Specifically, a server is only permitted to send a PUSH_PROMISE frame on a client initiated stream.

A better error message here would be good.

I figured that would be the case but, although I don't show it, after checking the value of pushallowed which came back true, I figured why not try.

@jasnell

Thanks for the quick response though. I can quit banging my head against that brick wall. @jasnell Should I leave this open or close the issue?

Let's leave this open. Some API and doc improvements would be worthwhile

http2: explicitly disallow nested push streams

@jasnell

@jasnell Thanks, I ran into this issue again just the other day. You're a rockstar!!

http2: explicitly disallow nested push streams

Navigation Menu

Repository navigation

Nested HTTP/2 pushStream fails with error #19095

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Nested HTTP/2 pushStream fails with error #19095

Description

Activity

jasnell commented on Mar 2, 2018

jasnell commented on Mar 2, 2018

robbie-mac commented on Mar 3, 2018

robbie-mac commented on Mar 3, 2018

jasnell commented on Mar 3, 2018

robbie-mac commented on Aug 14, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions