test/doctool/test-make-doc.js fails if .DS_Store exists #21519

Activity

1. devsnek

   added

   docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Jun 25, 2018
2. vsemozhetbyt commented on Jun 25, 2018

   

   vsemozhetbyt

   on Jun 25, 2018

   Contributor

   More actions

   PR to fix: #21531
3. vsemozhetbyt

   closed this as completedin 759809fon Jun 27, 2018
4. targos

   added a commit that references this issue on Jun 28, 2018

   test: skip non-doc files in test-make-doc checks

   ...

   623cf11
5. devsnek commented on Jul 14, 2018

   

   devsnek

   on Jul 14, 2018

   MemberAuthor

   More actions

   === release test-make-doc ===
   Path: doctool/test-make-doc
   assert.js:270
       throw err;
       ^
   
   AssertionError [ERR_ASSERTION]: _toc.html does not not match TOC
       at Object.<anonymous> (/Users/gus/Desktop/misc/nodejs/node/test/doctool/test-make-doc.js:45:10)
       at Module._compile (internal/modules/cjs/loader.js:689:30)
       at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
       at Module.load (internal/modules/cjs/loader.js:599:32)
       at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
       at Function.Module._load (internal/modules/cjs/loader.js:530:3)
       at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
       at startup (internal/bootstrap/node.js:266:19)
       at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3)
   Command: out/Release/node /Users/gus/Desktop/misc/nodejs/node/test/doctool/test-make-doc.js
   

   /cc @vsemozhetbyt
6. devsnek

   reopened this on Jul 14, 2018
7. vsemozhetbyt commented on Jul 14, 2018

   

   vsemozhetbyt

   on Jul 14, 2018

   Contributor

   More actions

   Just delete _toc.html or clean the out/doc folder: we have no _toc.* files anymore.
8. vsemozhetbyt commented on Jul 14, 2018

   

   vsemozhetbyt

   on Jul 14, 2018

   Contributor

   More actions

   Refs: _toc.md was deleted in the #21637 and _toc.html is not generated anymore, so it seems it is just an artifact from the previous builds.
9. lundibundi commented on Aug 1, 2018

   

   lundibundi

   on Aug 1, 2018

   Last edited by lundibundi

   Member

   More actions

   @devsnek that is #21912. It is now resolved by adding a new log to the error of suggesting to remove the relevant file.
   Should be resolved.
10. devsnek

    closed this as completedon Aug 1, 2018
11. sjarmak

    added a commit that references this issue on Jul 27, 2026

    test: skip non-doc files in test-make-doc checks

    ...

    759809f