Skip to content

Travis linter false-negatives for commit message checks #23737

Closed
#23739
Closed
Travis linter false-negatives for commit message checks#23737
#23739
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.flaky-testIssues and PRs involving tests that fail intermittently in CI.metaIssues and PRs related to the general management of the project.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@mmarchini
mmarchini
opened on Oct 18, 2018

Saw this on two PRs today (#23512 and #22079), Travis is complaining that "subsystem is missing". In both cases commit message is following our guidelines and have a valid subsystem in their titles.

Activity

  1. mmarchini
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Oct 18, 2018

  2. richardlau commented on Oct 18, 2018

    @richardlau
    richardlau
    on Oct 18, 2018
    Member

    #23725

  3. refack commented on Oct 18, 2018

    @refack
    refack
    on Oct 18, 2018
    Contributor

    Opened #23739 to stop linting...

  4. refack
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    metaIssues and PRs related to the general management of the project.
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Oct 18, 2018

  5. richardlau commented on Nov 6, 2018

    @richardlau
    richardlau
    on Nov 6, 2018
    Member

    The original issue is that Travis was misidentifying the commits for a PR.

    Rather than rely on Travis to work out which commits should be linted, #24030, #24076, #24093 changed the Travis linter to use GitHub's API to query for commits for the PR being tested so should now be consistent with the list of commits for a PR in the GitHub web UI.

  6. richardlau
    closed this as completedon Nov 6, 2018
  7. refack
    added a commit that references this issue on Nov 6, 2018

    build,meta: don't fail Travis for commit message

    bec505b
  8. targos
    added a commit that references this issue on Nov 6, 2018

    build,meta: don't fail Travis for commit message

    26c1988
  9. kiyomizumia
    added a commit that references this issue on Nov 15, 2018

    build,meta: don't fail Travis for commit message

    b28788c
  10. codebytere
    added a commit that references this issue on Nov 29, 2018

    build,meta: don't fail Travis for commit message

    fdfec16
  11. MylesBorins
    added 2 commits that reference this issue on Nov 29, 2018

    build,meta: don't fail Travis for commit message

    61458c4

    build,meta: don't fail Travis for commit message

    83b8c1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.flaky-testIssues and PRs involving tests that fail intermittently in CI.metaIssues and PRs related to the general management of the project.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions