esm loader error not catchable #24175

Activity

1. devsnek commented on Nov 6, 2018

   

   devsnek

   on Nov 6, 2018

   Last edited by devsnek

   Member

   More actions

   resolution errors are "early" errors, meaning they occur before evaluation. to test this you can spawn a child process and test the stdout.

   nvm i see what you mean now, i'm looking into it.
2. devsnek

   added

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.Issues related to the Code-and-Learn events and PRs submitted during the events.

   esmIssues and PRs related to the ECMAScript Modules implementation.Issues and PRs related to the ECMAScript Modules implementation.

   on Nov 6, 2018
3. franher commented on Nov 6, 2018

   

   franher

   on Nov 6, 2018

   ContributorAuthor

   More actions

   PR with the test case ready to land as soon this issue is resolved: #24183
4. mhdawson commented on Nov 6, 2018

   

   mhdawson

   on Nov 6, 2018

   Member

   More actions

   @MylesBorins who is the best person to ask to take a look at this to confirm if our understanding that this is a bug is correct?
5. devsnek commented on Nov 6, 2018

   

   devsnek

   on Nov 6, 2018

   Last edited by devsnek

   Member

   More actions

   @mhdawson i'm looking into it now. i can confirm that not being able to catch() this is a bug.

   👍React with 👍2Reacted by Fran Herrero and Anna Henningsen
6. mhdawson commented on Nov 6, 2018

   

   mhdawson

   on Nov 6, 2018

   Member

   More actions

   @devsnek thanks!
7. devsnek commented on Nov 6, 2018

   

   devsnek

   on Nov 6, 2018

   Member

   More actions

   weee okay so the problem is the resolve hook. the actual error being generated is (as i said earlier by coincidence) an early error. it is trying to resolve the test file, but since the resolve hook just returns an empty string, it won't work.

   if the loader is changed to this it works cc @franher

   export async function resolve(specifier, parent, defaultResolve) {
     if (specifier === 'does_not_exist') {
       return { url: 'does_not_exist', format: 'builtin' };
     }
     return defaultResolve(specifier, parent);
   }
8. franher commented on Nov 6, 2018

   

   franher

   on Nov 6, 2018

   ContributorAuthor

   More actions

   ohh I see @devsnek Thank you for your support.

   I've just pushed the changes to the PR with the proper resolve hook.

   I close this issue.
9. franher

   closed this as completedon Nov 6, 2018