You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
http: deprecate/rename finished in favour of ended #28651
What is currently the finished property in http/1 is actually what is ended in the world of streams.
Would it be an idea to deprecate finished (e.g. remove from docs and/or add warning) and add an alias/property called ended instead to better match the streams spec and avoid confusion?
Activity
[-]http: deprecate finished in favour of ended alias[/-][+]http: deprecate/rename finished in favour of ended[/+]Trott commentedon Jul 13, 2019
@nodejs/http @nodejs/streams
mcollina commentedon Jul 14, 2019
I'm in favor of a doc-deprecation.
ronag commentedon Jul 14, 2019
@mcollina I assume that means that you are not in favor of adding a
endedgetter?ronag commentedon Aug 24, 2019
This has been sorted with
writableEndedandwritableFinished. Deprecation is separate thing.doc: deprecate http finished
doc: deprecate http finished
doc: deprecate http finished
doc: deprecate http finished