Repository navigation

undocumented "lookup" option in http.request / http.get #30171

Closed

Labels

opened

on Oct 30, 2019

Hi there, is the lookup option for http.request intentionally undocumented? Sindre's got uses it but I'd want to know if it's stable or not since it's not documented?

node/test/parallel/test-http-client-timeout-option-with-agent.js

Line 12 in b361f95

lookup: () => {},
node/test/parallel/test-http-client-req-error-dont-double-fire.js

Line 18 in dcc5e51

lookup: common.mustCall(errorLookupMock())
https://github.com/szmarczak/cacheable-lookup
https://nodejs.org/api/http.html#http_http_request_options_callback

bnoordhuis
added
docIssues and PRs related to Node.js documentation.

httpIssues and PRs related to the http subsystem.
on Oct 31, 2019
lpinca commented on Oct 31, 2019
lpinca
on Oct 31, 2019
Member
Yes it's stable, it is forwarded to https://nodejs.org/api/net.html#net_socket_connect_options_connectlistener
davalapar commented on Nov 1, 2019
davalapar
on Nov 1, 2019
Author
awesome thank you!

i think it also defaults to https://nodejs.org/api/dns.html#dns_dns_lookup_hostname_options_callback, correct?

this is amazing 🎉 🎉
lpinca
added a commit that references this issue on Nov 10, 2019
doc: add lookup to http.request() options
fbcdd60
danbev
closed this as completedin 5bd6f51 on Nov 13, 2019
MylesBorins
added a commit that references this issue on Nov 17, 2019
doc: add lookup to http.request() options
c832565
targos
added a commit that references this issue on Dec 1, 2019
doc: add lookup to http.request() options
671e028
MylesBorins
added a commit that references this issue on Dec 17, 2019
doc: add lookup to http.request() options
d2c85f3

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests