Skip to content

stream: autoDestroy: true #30625

Closed
Closed
stream: autoDestroy: true#30625
Labels
metaIssues and PRs related to the general management of the project.streamIssues and PRs related to Node.js streams.

Description

@ronag
ronag
opened on Nov 24, 2019

This is a tracking issue for migrating all node core modules to use autoDestroy: true

Activity

  1. ronag commented on Nov 24, 2019

    @ronag
    ronag
    on Nov 24, 2019
    MemberAuthor

    I think to a certain degree this would be simpler if done at the same time as migrating to construct (if that gets merged).

  2. ronag commented on Nov 24, 2019

    @ronag
    ronag
    on Nov 24, 2019
    MemberAuthor

    Related #30621, #30623

  3. ronag
    added
    metaIssues and PRs related to the general management of the project.
    streamIssues and PRs related to Node.js streams.
    on Feb 9, 2020

  4. ronag commented on Apr 19, 2020

    @ronag
    ronag
    on Apr 19, 2020
    MemberAuthor

    Crossed out http2. Does not seem feasible to move to http2. Unsure if http2 lifecycle adheres to the default streams life cycle.

  5. dnlup commented on Apr 22, 2020

    @dnlup
    dnlup
    on Apr 22, 2020
    Contributor

    Is _http_ougoing.js needed? I think _http_incoming.js can be marked as done (#30623)

  6. ronag commented on Apr 22, 2020

    @ronag
    ronag
    on Apr 22, 2020
    MemberAuthor

    Is _http_ougoing.js needed?

    Is not a real stream, yet.

    I think _http_incoming.js can be marked as done (#30623)

    No, it's still not using autoDestroy, https://github.com/nodejs/node/pull/30623/files#diff-f7d8a311cc7ac30522e414465bda2229R51

  7. dnlup commented on Apr 22, 2020

    @dnlup
    dnlup
    on Apr 22, 2020
    Contributor

    Thank you @ronag for the clarification. I misinterpreted this issue by considering that the modules should have been just refactored to be aware of the new default autoDestroy: true option in streams. I would like to help with _http_incoming.js then, I'll try to work on it.

  8. nodejs-github-bot
    added 7 commits that reference this issue on Dec 17, 2020

    http: use `autoDestroy: true` in incoming message

    55e83cb

    http: reafactor incoming message destroy

    6120028

    http: fix lint error in incoming message

    70eaf55

    http: add comments in _http_incoming

    5ae9690

    http: remove trailing space

    f20a88f

    http: use standard args order in IncomingMEssage onError

    a6bf74e

    http: add test for incomingmessage destroy

    8154e47

  9. ronag commented on Dec 17, 2020

    @ronag
    ronag
    on Dec 17, 2020
    MemberAuthor

    This has been fixed

  10. ronag
    closed this as completedon Dec 17, 2020
  11. targos
    added 7 commits that reference this issue on Dec 21, 2020

    http: use `autoDestroy: true` in incoming message

    25d7e90

    http: reafactor incoming message destroy

    397e31e

    http: fix lint error in incoming message

    4b81d79

    http: add comments in _http_incoming

    f11a648

    http: remove trailing space

    60b5e69

    http: use standard args order in IncomingMEssage onError

    36b4ddd

    http: add test for incomingmessage destroy

    213dcd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    metaIssues and PRs related to the general management of the project.streamIssues and PRs related to Node.js streams.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions