Repository navigation
The sensitiveHeaders HTTP2 symbol should be initialized via Symbol.for instead #36282
Description
Activity
In the documentation(https://github.com/nodejs/node/blob/master/doc/guides/using-symbols.md), there are references to how global Symbols are used.
Global symbols should be preferred when a developer-facing interface is needed to allow behavior customization, i.e., metaprogramming.
After trying to read the related Issue (#34091) and Pull Request(#34145).
I think that sensitiveHeaders is a feature that developers are using in the http2 module, not a developer-facing interface, and naming it
nodejs.http2.sensitiveHeadersmay be a mistake.Details still need to be explained by @addaleax , if this is a mistake, I will file a Pull Request to fix it.
Global symbols should be preferred when a developer-facing interface is needed to allow behavior customization, i.e., metaprogramming.
That's exactly the case here. If you declare the symbol in your headers object then the headers in that array won't be compressed. It's custom behavior, isn't it?
I think that sensitiveHeaders is a feature that developers are using in the http2 module, not a developer-facing interface
Following your thinking, let's revert
nodejs.util.promisify.customandnodejs.util.inspect.custom, because developers are using it in theutilmodule.A module is an interface. API stands for Application Programming Interface.
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
Is your feature request related to a problem? Please describe.
node/lib/internal/http2/util.js
Line 35 in 6eec858
Currently to use the symbol we need to import it from the
http2module. A better solution would be to useSymbol.forlike in the case of custom inspect symbol.Describe the solution you'd like
Describe alternatives you've considered
None.