Repository navigation
Failing test on master: EnvironmentTest.LoadEnvironmentWithSource: FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal. #40605
Description
Version
master @ 9ebdba4
Platform
Darwin Mac 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64
What steps will reproduce the bug?
Fresh checkout, then:
./configure --ninja --node-builtin-modules-path $(pwd)
JOBS=8 make
make testThe test run stops on this error:
[----------] 18 tests from EnvironmentTest
[ RUN ] EnvironmentTest.EnvironmentWithESMLoader
[ OK ] EnvironmentTest.EnvironmentWithESMLoader (45 ms)
[ RUN ] EnvironmentTest.EnvironmentWithNoESMLoader
[ OK ] EnvironmentTest.EnvironmentWithNoESMLoader (39 ms)
[ RUN ] EnvironmentTest.PreExecutionPreparation
[ OK ] EnvironmentTest.PreExecutionPreparation (38 ms)
[ RUN ] EnvironmentTest.LoadEnvironmentWithCallback
[ OK ] EnvironmentTest.LoadEnvironmentWithCallback (38 ms)
[ RUN ] EnvironmentTest.LoadEnvironmentWithSource
FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
1: 0x10b637bb5 node::Abort() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
2: 0x10b637d3f node::OnFatalError(char const*, char const*) [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
3: 0x10bad5900 v8::api_internal::ToLocalEmpty() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
4: 0x10b51342b EnvironmentTest_LoadEnvironmentWithSource_Test::TestBody() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
5: 0x10b79b448 testing::Test::Run() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
6: 0x10b79c788 testing::TestInfo::Run() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
7: 0x10b79d1e7 testing::TestSuite::Run() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
8: 0x10b7ad639 testing::internal::UnitTestImpl::RunAllTests() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
9: 0x10b7acb0f testing::UnitTest::Run() [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
10: 0x10b7b4faa main [/Users/Geoffrey.Booth/Sites/node/out/Release/cctest]
11: 0x7fff2032af3d start [/usr/lib/system/libdyld.dylib]
12: 0x2
make[1]: *** [cctest] Abort trap: 6
make: *** [test] Error 2
How often does it reproduce? Is there a required condition?
Every time. I’ve tried on two machines.
Additional information
cc @nodejs/build-files
Activity
src: make LoadEnvironment with string work with builtin modules path
test: skip macos sandbox test with builtin modules path
targos commentedon Oct 26, 2021
It happens because this test doesn't work with
--node-builtin-modules-path.Proposed fix: #40607
GeoffreyBooth commentedon Oct 26, 2021
@targos Should we have a CI job that tries to build and test with
--ninjaand/or--node-builtin-modules-path? That would prevent bugs like this in the future, though it might be a lot of wasted CI resources for a low probability bug.targos commentedon Oct 27, 2021
Yeah, I'm not sure it's worth spending those resources for a build path that's not really supported outside of core development.
test: skip macos sandbox test with builtin modules path
src: make LoadEnvironment with string work with builtin modules path
test: skip macos sandbox test with builtin modules path
src: make LoadEnvironment with string work with builtin modules path
test: skip macos sandbox test with builtin modules path
src: make LoadEnvironment with string work with builtin modules path