Repository navigation
"TypeError: Cannot redefine property: window" (v18.6.0) #47563
Description
Version
v18.16.0
Platform
21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64
Subsystem
No response
What steps will reproduce the bug?
const jsdom = new JSDOM('<!doctype html><html><body></body></html>');
global.window = jsdom.window as any;How often does it reproduce? Is there a required condition?
Error is consistent. This error did not occur when using Node 18.15.0, and also does not occur when using Node 19.9.0.
What is the expected behavior? Why is that the expected behavior?
Expected behavior is no error.
What do you see instead?
TypeError: Cannot redefine property: window
Additional information
Same issue as: #47310
Similar to that issue, I've run into this error when running tests that use JSDom:
- Save the following as "test.js":
/**
* @jest-environment jsdom
*/
"use strict"
global.window = {};
describe("test", () => {
it("runs", () => {
expect(1 + 1).toEqual(2);
});
});- Run
npm i jest jest-environment-jsdom - Run
npx jest
Activity
bnoordhuis commentedon Apr 15, 2023
That bug was fixed by #46615 but it hasn't been back-ported to v18.x yet. That happens automatically after some time so it'll likely show up in a release in the next few weeks. You can follow the linked pull request to get notified.
Fix node 18.16.0 tests nodejs/node#47563
Fix node 18.16.0 tests
Specifying node 18 version due to nodejs/node#47563
chore: downgrade node version required
chore(checks): pin node version to 18.15 (#10390)
chore: downgrade node version required
chore: downgrade node version required (#393)
fix: pin node version to 18.15
pre commentedon May 4, 2023
@bnoordhuis are you aware whether the backport has already happened?
bnoordhuis commentedon May 4, 2023
It's been back-ported to v19.x but not to v18.x yet. Give it a few more weeks.
schinery commentedon May 4, 2023
Is odd as I've just tried bumping from 18.15.0 to 18.16.0 and now get this
TypeError: Cannot redefine property: windowin a test.Will try again when another v18.x is released.
chore(automerge): get masthead-v2-dev back up to date (#10423)
chore(workflows): on-pr-and-trunk_one-app-unit-and-lint-tests exclude…
14 remaining items
Enet4 commentedon Jun 27, 2023
The patch has already been staged for an upcoming 18.x release (comment):
Until then, sticking to Node.js v18.15.0 should work.
ci: bump node to 18.15
ci: bump node to 18.15
Daniel8564 commentedon Jun 29, 2023
we have done like above to mock addEventListener:
ci: bump node to 18.15.0
ci: bump node to 18.15.0
ci: bump node to 18.15.0
feat: support AppImage releases (#1379)
chore(masthead-v2): prepare to release (#10635)
chore(masthead v2): merge masthead dev to release (#10638)
arggrande commentedon Jul 21, 2023
Hey folks, I can confirm this seems to have been fixed with the release of v18.17.0.
I was in the process (ha) of doing an upgrade of our Node environments to 18.16.0, and hit this issue.
the nullish coalescing operator (the
??=) workaround did work for me however after checking what the latest LTS was (being 18.17.0) I upgraded accordingly, removed the nullish coalescing operator from my tests, and it seems to work perfectly now.I'll update this comment if anything changes, but I think v18.17.0+ we're good to go!
temporarily pin node 18.15 nodejs/node#47563
chore(masthead-v2): merge dev into main (#11131)
chore(masthead-v2-alpha): merge alpha dev changes into alpha main (#1…
chore(masthead-v2-alpha): merge alpha dev changes into alpha main (ca…